Command palette interrupt/restart not there for a python file

[rchiodo]

No description provided.

[rchiodo]

Was looking at this. Kinda confusing as there's more than one restart/interrupt.

jupyter.notebookeditor.restartkernel is the one for notebooks, but is also now used in the new interactive window
jupyter.restartkernel is the one we used to use for the interactive window (i think).

So the first one is probably the one to fix. The context is a little messy though.

You'd need a file that's active that has code cells but there's also an IW open that's related to the code cells. At least to be completely correct.

[joyceerhl]

The new interactive window does not use jupyter.notebookeditor.restartkernel:

vscode-jupyter/package.json

Lines 868 to 883 in add2eb6

	"interactive/toolbar": [
	{
	"command": "jupyter.interactive.clearAllCells",
	"group": "navigation@0",
	"when": "isWorkspaceTrusted"
	},
	{
	"command": "jupyter.restartkernel",
	"group": "navigation@1",
	"when": "isWorkspaceTrusted"
	},
	{
	"command": "jupyter.interruptkernel",
	"group": "navigation@2",
	"when": "isWorkspaceTrusted"
	},

[joyceerhl]

These context keys aren't being properly set

vscode-jupyter/package.json

Line 1192 in add2eb6

"when": "jupyter.haveinteractive && jupyter.ispythonorinteractiveeactive && isWorkspaceTrusted"

[DonJayamanne]

Duplicate of #330
I have no idea why we never fixed any of them..
I think we should just review all the commands

[rchiodo]

I don't think this is fixed. Or at least it doesn't behave the way I would expect.

Shows up even after closing the interactive window. I suppose that's better than it not being there.

Additionally if I have two IW's open, it's not clear which one it's going to restart. Additionally the restart doesn't put out the status message.

I think you enabled the wrong command? Well maybe. The other command might have had the restart message show up. At least it used to.

[joyceerhl]

restart doesn't put out the status message.

The restart message shows up for me, and both the jupyter.notebookeditor.restartkernel and jupyter.restartkernel commands have the same shared command handler. Is there another command I should have looked at? https://github.com/microsoft/vscode-jupyter/blob/69fda26e079236e98e8aab580f27f2e36ef3ce53/src/client/datascience/jupyter/kernels/kernelCommandListener.ts

Which version of the Jupyter extension do you have? I'm on v2021.8.2031173646.

[rchiodo]

This one:

Version: 2021.8.2031173646

No restart message shows up at all. Might be because of me not using ZMQ though. Let me check.

[rchiodo]

No even with ZMQ enabled it fails to show a restart message. Even using the toolbar.

[rchiodo]

Restart message is a different issue.