Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking 'Change Kernel' for interactive window started from script file does nothing #7476

Closed
Tracked by #7168
joyceerhl opened this issue Sep 9, 2021 · 0 comments · Fixed by #7482
Closed
Tracked by #7168
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window upstream-vscode Blocked on upstream VS code verified Verification succeeded

Comments

@joyceerhl
Copy link
Contributor

  1. Have an active interpreter without ipykernel installed
  2. Start the interactive window from a script file
  3. Click 'Change Kernel' on the dialog that comes up
  4. 🐛 Nothing happens. This is because notebook.selectKernel doesn't work if there isn't an active notebook editor

Based on discussion at notebook sync this morning, we can modify notebook.selectKernel to take the notebook widget that the kernel picker should be invoked for (interactive.open returns the notebook editor widget).

@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug upstream-vscode Blocked on upstream VS code interactive-window Impacts interactive window labels Sep 9, 2021
@joyceerhl joyceerhl self-assigned this Sep 9, 2021
@joyceerhl joyceerhl added this to the September 2021 milestone Sep 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2021
@DonJayamanne DonJayamanne added the verified Verification succeeded label Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window upstream-vscode Blocked on upstream VS code verified Verification succeeded
Projects
None yet
2 participants