Allow invoking kernel picker for inactive notebook given NotebookEditor in notebook.selectKernel command args
#132879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`notebook.selectKernel` is now an API command that takes target `NotebookEditor` as an arg
joyceerhl
commented
Sep 10, 2021
| }) | ||
| ], | ||
| ApiCommandResult.Void); | ||
| this._commands.registerApiCommand(selectKernelApiCommand); |
There was a problem hiding this comment.
@rebornix I wasn't sure where to move this to. Would extHostApiCommands.ts be the right place?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: microsoft/vscode-jupyter#7476
GIF of combined VS Code and Jupyter extension changes:
