Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive window interactive.history.previous and interactive.history.next do not persist history position when reexecuting commands #131659

Closed
joyceerhl opened this issue Aug 25, 2021 · 3 comments · Fixed by #225725
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window regression Something that used to work is now broken under-discussion Issue is under discussion for relevance, priority, approach verified Verification succeeded
Milestone

Comments

@joyceerhl
Copy link
Collaborator

  1. Execute four cells from the interactive window input box, e.g. print(1), print(2), print(3), print(4)
  2. To reexecute multiple commands from earlier in your history, e.g. print(1) and print(2) use interactive.history.previous via the up arrow
  3. After executing an entry from earlier in the history e.g. print(2), scroll position resets to the bottom of the history, and you have to start over and scroll up from the most recent command (4 -> 3 - > 2 -> 1). This can be frustrating for users who are trying to reexecute multiple commands. Note also that the original interactive window used to preserve your scroll history in the interactive window so that you didn't have to scroll back up through the entire history, and users have complained about this behavior change: Interactive Window Command History Search / Autocomplete vscode-jupyter#4716 (comment) Interactive Window Command History Search / Autocomplete vscode-jupyter#4716 (comment)
@joyceerhl joyceerhl added this to the September 2021 milestone Aug 25, 2021
@joyceerhl joyceerhl changed the title Interactive window interactive.history.previous and interactive.history.next do not persist history position Interactive window interactive.history.previous and interactive.history.next do not persist history position when reexecuting commands Aug 25, 2021
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Aug 30, 2021
@joyceerhl
Copy link
Collaborator Author

joyceerhl commented Sep 10, 2021

The expectation is that the interactive window input behaves just like a REPL. #127498 would address this. Per discussion with @rebornix we should have shared logic for handing history traversal.

@rebornix rebornix added under-discussion Issue is under discussion for relevance, priority, approach and removed bug Issue identified by VS Code Team member as probable bug labels Sep 23, 2021
@greazer greazer added bug Issue identified by VS Code Team member as probable bug regression Something that used to work is now broken labels Sep 29, 2021
@greazer greazer modified the milestones: September 2021, October 2021 Sep 29, 2021
@joyceerhl joyceerhl removed their assignment Oct 26, 2021
@rebornix rebornix modified the milestones: October 2021, On Deck Oct 26, 2021
@amunger amunger self-assigned this Aug 16, 2022
@rogerlga
Copy link

rogerlga commented Jan 7, 2023

Any news on that? I agree with the PR that the current behavior is quite frustrating and deserves further attention.

@jaymegordo
Copy link

Yes this is one of my main frustrations with the IW still. At minimum I just want the up arrow to go to the last executed code, not have cycle through like 20 cells every time I need to re-run something. And it did used to work this way ~1.5 yrs ago.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window regression Something that used to work is now broken under-discussion Issue is under discussion for relevance, priority, approach verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants