Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interrupt button is enabled even when there's no code running in interactive window #7269

Closed
Tracked by #7168
DonJayamanne opened this issue Aug 24, 2021 · 5 comments · Fixed by #7488
Closed
Tracked by #7168
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window verified Verification succeeded

Comments

@DonJayamanne
Copy link
Contributor

In notebooks,

  • the interrupt icon is only enabled when we have some code running.
  • Similarly variable icon is only enabled when variable view is not visible

In interactive window:

  • The interrupt is always enabled even when no code is running.
  • Ideally it should be disabled (like in notebooks)..
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Aug 24, 2021
@DonJayamanne DonJayamanne changed the title Interrupt button is enabled even when there's no code running Interrupt button is enabled even when there's no code running in interactive window Aug 24, 2021
@joyceerhl
Copy link
Contributor

FWIW I've personally never found the disable-when-not-running behavior compelling. I invariably wonder why the button is disabled. Same goes for the variable explorer being disabled when it's already open--clicking should be a noop but the button being disabled is distracting for me personally.

@DonJayamanne
Copy link
Contributor Author

personally never found the disable-when-not-running behavior compelling. I invariably wonder why the button is disabled

I think vs code does the same thing (disable the commands, via enablement & when clauses),
Else one would end up clicking on this and it does absolutely nothing (thats what i did, i thought it was the restart button, then realized oh it was interrupt).

As for variable viewer, i think it could be argued that it should be enabled, as that launches the UI (sets focus to the UI element, or at least that's what i think).

@greazer greazer added interactive-window Impacts interactive window and removed needs-triage labels Aug 25, 2021
@joyceerhl joyceerhl mentioned this issue Sep 7, 2021
17 tasks
@burkeholland
Copy link

Related: Interrupt button also seems to not be enabled when doing "Run all above". It works if you click it, but it doesn't show as enabled.

@joyceerhl
Copy link
Contributor

@burkeholland are you seeing this in notebooks or the interactive window?

@burkeholland
Copy link

Interactive window....

interrupt.mp4

@joyceerhl joyceerhl added this to the September 2021 milestone Sep 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2021
@DonJayamanne DonJayamanne added the verified Verification succeeded label Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window verified Verification succeeded
Projects
None yet
4 participants