Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pip install the DS packages in Jupyter extension if Python extension fails to install them #8325

Closed
DonJayamanne opened this issue Nov 22, 2021 · 1 comment
Closed

Pip install the DS packages in Jupyter extension if Python extension fails to install them #8325

DonJayamanne opened this issue Nov 22, 2021 · 1 comment
Assignees
@DonJayamanne
Labels
verified Verification succeeded
Milestone
November 2021

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Nov 22, 2021 •
edited
Loading

Problem:

Today when user is prompted to install packages such as ipykernel or the like, we run the necessary installation commands in the VS Code terminal. However if user has a terminal such as gitbash or the like setup, then installations can fail and users are unable to run cells.

Solution
Attempt to run python -m pip install outside the terminal in jupyter extension, if that fails then fall back to the old approach.
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Nov 22, 2021
@DonJayamanne DonJayamanne self-assigned this Nov 22, 2021
@DonJayamanne DonJayamanne removed the bug Issue identified by VS Code Team member as probable bug label Nov 22, 2021
@DonJayamanne DonJayamanne added this to the November 2021 milestone Nov 22, 2021
This was referenced Nov 22, 2021
Closed
Merged
Closed
@DonJayamanne DonJayamanne mentioned this issue Nov 24, 2021
Closed
5 tasks
@DonJayamanne
Copy link
Contributor Author

Test plan here #8359

@rchiodo rchiodo added the verified Verification succeeded label Dec 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
2 participants
@DonJayamanne @rchiodo