Pip install DS packages if Python ext fails #8326

DonJayamanne · 2021-11-22T18:45:05Z

DonJayamanne · 2021-11-22T18:45:56Z

src/client/telemetry/index.ts

            | 'dismissed'; // User chose to dismiss the prompt.
        resourceType?: 'notebook' | 'interactive';
        /**
         * Hash of the resource (notebook.uri or pythonfile.uri associated with this).
         * If we run the same notebook tomorrow, the hash will be the same.
         */
        resourceHash?: string;
+        pythonEnvType?: EnvironmentType;


Better telemetry, to easily identify what environments don't work.

DonJayamanne · 2021-11-22T18:46:45Z

src/client/common/installer/backupPipInstaller.ts

+            return false;
+        }
+        // Check if pip is installed.
+        const isPipInstalled = await this.isInstalled(Product.pip, interpreter);


For now we're only going to install DS pacakges via Pip for Global python environments.
(based on the new telemetry if this works, we can extend this to others & look at whats going on in terminals for python extension)

codecov-commenter · 2021-11-22T20:51:38Z

Codecov Report

Merging #8326 (c9dea22) into main (40e744f) will decrease coverage by 0%.
The diff coverage is 30%.

❗ Current head c9dea22 differs from pull request most recent head 2217c6d. Consider uploading reports for the commit 2217c6d to get more accurate results

@@          Coverage Diff           @@
##            main   #8326    +/-   ##
======================================
- Coverage     72%     71%    -1%     
======================================
  Files        373     374     +1     
  Lines      23323   23424   +101     
  Branches    3570    3584    +14     
======================================
+ Hits       16844   16853     +9     
- Misses      5029    5116    +87     
- Partials    1450    1455     +5

Impacted Files	Coverage Δ
...cience/data-viewing/dataViewerDependencyService.ts	`87% <ø> (ø)`
...interpreter/jupyterInterpreterDependencyService.ts	`75% <ø> (ø)`
...science/jupyter/kernels/kernelDependencyService.ts	`82% <ø> (ø)`
src/client/telemetry/index.ts	`63% <ø> (ø)`
src/client/common/installer/backupPipInstaller.ts	`28% <28%> (ø)`
src/client/common/installer/productInstaller.ts	`57% <34%> (-5%)`	⬇️
src/client/common/utils/localize.ts	`95% <100%> (+<1%)`	⬆️
...ent/datascience/jupyter/pythonVariableRequester.ts	`68% <0%> (-6%)`	⬇️
...tascience/jupyter/kernels/kernelCommandListener.ts	`66% <0%> (-4%)`	⬇️
src/client/datascience/jupyter/kernelVariables.ts	`56% <0%> (-3%)`	⬇️
... and 5 more

DonJayamanne commented Nov 22, 2021

View reviewed changes

Pip install DS packages if Python ext fails

2217c6d

DonJayamanne force-pushed the pipInstallIpyKernelInJupyter branch from c9dea22 to 2217c6d Compare November 22, 2021 20:51

DonJayamanne added 4 commits November 22, 2021 13:58

Fixes

8121bf5

Fixes

f9278c3

MIsc

92e094d

fix formatting

484ea9a

DonJayamanne marked this pull request as ready for review November 23, 2021 00:01

DonJayamanne requested a review from a team as a code owner November 23, 2021 00:01

DonJayamanne merged commit 5c76830 into main Nov 23, 2021

DonJayamanne deleted the pipInstallIpyKernelInJupyter branch November 23, 2021 00:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pip install DS packages if Python ext fails #8326

Pip install DS packages if Python ext fails #8326

DonJayamanne commented Nov 22, 2021

DonJayamanne Nov 22, 2021

DonJayamanne Nov 22, 2021 •

edited

Loading

codecov-commenter commented Nov 22, 2021

Pip install DS packages if Python ext fails #8326

Pip install DS packages if Python ext fails #8326

Conversation

DonJayamanne commented Nov 22, 2021

DonJayamanne Nov 22, 2021

Choose a reason for hiding this comment

DonJayamanne Nov 22, 2021 • edited Loading

Choose a reason for hiding this comment

codecov-commenter commented Nov 22, 2021

Codecov Report

DonJayamanne Nov 22, 2021 •

edited

Loading