Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First cell in a notebook has invalid colorization #8437

Closed
rchiodo opened this issue Dec 2, 2021 · 3 comments · Fixed by #8438
Closed

First cell in a notebook has invalid colorization #8437

rchiodo opened this issue Dec 2, 2021 · 3 comments · Fixed by #8438
Assignees
@rchiodo
Labels
bug Issue identified by VS Code Team member as probable bug notebook-intellisense Intellisense & other language features in notebook cells for any language verified Verification succeeded
Milestone
November 2021

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Dec 2, 2021

image

Caused by not filtering out the hidden lines during edits.
@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Dec 2, 2021
@rchiodo rchiodo mentioned this issue Dec 2, 2021
Merged
@rchiodo rchiodo added notebook-intellisense Intellisense & other language features in notebook cells for any language regression and removed needs-triage labels Dec 2, 2021
@rchiodo rchiodo self-assigned this Dec 2, 2021
@rchiodo rchiodo added this to the November 2021 milestone Dec 2, 2021
@rchiodo rchiodo mentioned this issue Dec 2, 2021
Merged
@meganrogge
Copy link

was this always happening @rchiodo ? how do I check that it's been fixed?

@meganrogge meganrogge added the verification-steps-needed Steps to verify are needed for verification label Dec 3, 2021
@rchiodo
Copy link
Contributor Author

rchiodo commented Dec 3, 2021 •
edited
Loading

Sorry, here's the repro steps:

  1. Add something to your jupyter.runStartupCommands. Something like x = 11111. This will get 'prepended' to the behind the scenes concatenated file we use for intellisense.
  2. Open a notebook
  3. Type something in the first cell
  4. Verify colorization is correct.

@rchiodo rchiodo removed the verification-steps-needed Steps to verify are needed for verification label Dec 3, 2021
@rchiodo
Copy link
Contributor Author

rchiodo commented Dec 3, 2021

And this doesn't repro in stable. Bug caused in this release.

@meganrogge meganrogge added the verified Verification succeeded label Dec 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rchiodo rchiodo

Labels
bug Issue identified by VS Code Team member as probable bug notebook-intellisense Intellisense & other language features in notebook cells for any language verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

Successfully merging a pull request may close this issue.

Fix tokens in the first cell of a notebook microsoft/vscode-jupyter
2 participants
@rchiodo @meganrogge