Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokens in the first cell of a notebook #8438

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Dec 2, 2021

Fixes #8437

@rchiodo rchiodo requested a review from a team as a code owner December 2, 2021 21:23
@rchiodo rchiodo changed the title Rchiodo/fix_tokens_first_cell Fix tokens in the first cell of a notebook Dec 2, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #8438 (28076f5) into main (ecd9fe0) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #8438   +/-   ##
=====================================
  Coverage     71%     71%           
=====================================
  Files        375     375           
  Lines      23800   23800           
  Branches    3667    3667           
=====================================
+ Hits       17104   17111    +7     
+ Misses      5204    5201    -3     
+ Partials    1492    1488    -4     
Impacted Files Coverage Δ
src/client/datascience/jupyter/kernelVariables.ts 57% <0%> (+1%) ⬆️
...ence/editor-integration/cellHashProviderFactory.ts 100% <0%> (+2%) ⬆️
...ook/intellisense/pythonKernelCompletionProvider.ts 76% <0%> (+3%) ⬆️

@rchiodo rchiodo merged commit 4ebc068 into main Dec 2, 2021
@rchiodo rchiodo deleted the rchiodo/fix_tokens_first_cell branch December 2, 2021 22:16
rchiodo added a commit that referenced this pull request Dec 2, 2021
* Update to latest middleware

* Add news entry
rchiodo added a commit that referenced this pull request Dec 2, 2021
* Fix tokens in the first cell of a notebook (#8438)

* Update to latest middleware

* Add news entry

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First cell in a notebook has invalid colorization
3 participants