Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activation of environments does not work properly on multi-root environments #1476

Closed
DonJayamanne opened this issue Apr 24, 2018 · 0 comments · Fixed by #1691
Closed

Activation of environments does not work properly on multi-root environments #1476

DonJayamanne opened this issue Apr 24, 2018 · 0 comments · Fixed by #1691
Assignees
@DonJayamanne
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug
Milestone
May 2018

Comments

@DonJayamanne
Copy link

This is because we aren't passing in the resource to ITerminalServiceFactory.getTerminalService();
@DonJayamanne DonJayamanne added this to the May 2018 milestone Apr 24, 2018
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR area-terminal labels Apr 24, 2018
@DonJayamanne DonJayamanne self-assigned this Apr 24, 2018
@DonJayamanne DonJayamanne mentioned this issue May 15, 2018
Merged
5 tasks
DonJayamanne added a commit that referenced this issue May 21, 2018
@DonJayamanne
Ensure resource is passed into getTerminalService method (#1691)
16acb4b 
* Ensure resource is passed into getTerminalService method
* Use relative paths for prospector
* Fixes #1476
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
area-terminal bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
May 2018
Development

Successfully merging a pull request may close this issue.

Ensure resource is passed into getTerminalService method DonJayamanne/pythonVSCode
3 participants
@brettcannon @DonJayamanne @d3r3kk