Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure resource is passed into getTerminalService method #1691

Merged

Conversation

DonJayamanne
Copy link

Fixes #1476

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented May 15, 2018

Codecov Report

Merging #1691 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1691      +/-   ##
==========================================
- Coverage   71.49%   71.49%   -0.01%     
==========================================
  Files         277      277              
  Lines       13014    13017       +3     
  Branches     2344     2344              
==========================================
+ Hits         9305     9306       +1     
- Misses       3574     3575       +1     
- Partials      135      136       +1
Impacted Files Coverage Δ
src/client/common/installer/productInstaller.ts 59.18% <0%> (ø) ⬆️
src/client/common/installer/moduleInstaller.ts 48.14% <100%> (ø) ⬆️
src/client/linters/prospector.ts 82.6% <100%> (+2.6%) ⬆️
src/client/common/installer/pipEnvInstaller.ts 72.22% <100%> (ø) ⬆️
...rc/client/debugger/PythonProcessCallbackHandler.ts 52.96% <0%> (-1.32%) ⬇️
src/client/debugger/Main.ts 52.34% <0%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e26da1a...a7cd785. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 16acb4b into microsoft:master May 21, 2018
@DonJayamanne DonJayamanne deleted the issue1476GetTerminalService branch June 20, 2018 03:17
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activation of environments does not work properly on multi-root environments
2 participants