-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove synchronous process launches #15725
Comments
@DonJayamanne Do we need to run python there to check if it is valid? I feel like an file exists check should be enough for the variety of cases it handles there. |
A file check should be fairly cheap compared to executing Python itself. |
Sure thats much better, is there a way we can do this even without a synchronous file check (sync = still blocking node process, though its a significant improvement) |
I have looked into that class before. Turning functions in the class to I would say, give it a try to make that |
In configSettings.ts we have some code that launches python processes synchronously.
// const output = child_process.execFileSync(pythonPath, args, { encoding: 'utf8' });
This slows down other extensions when loading Python extension.
If user is working purely on python extension, then I guess this is ok to have.
However consider the following scenario:
Removing this code improves the load times of Jupyter notebooks significantly.
Related upstream issue causing serious perf issues in Jupyter Notebooks microsoft/vscode-jupyter#5211
Basically Jupyter Notebooks takes 20-30 seconds to load and we're trying to address that.
The text was updated successfully, but these errors were encountered: