Default behavior for analyzing of entire project in new language server

[DonJayamanne]

#2030
#1861

Currently the language server analyzes the entire project.
This can be turned off using the setting python.diagnostics.openFilesOnly: false

What should the default behavior be?

• Analyze entire project
• Analyze just the open file

Note: Today VSC Python displays errors (linter errors) for opened files.
With the introduction of the new language server, we're changing this default behavior to analyze entire project. This could both be a good thing as well as bad.

E.g. for someone working on a large code base, with Python 2.7 code, or similar, they could end up with 100s of errors (like me when using PTVSD, i see 880 errors).

Yes, the solution is as simple as turn off the feature to analyze opened file. This is similar to the pylint linter is not installed message. Once again, the solution is as simple as disabling it, but its annoying to have it as the default behavior.

My concern is users will start getting annoyed with these messages.

@Microsoft/pvsc-team

[MikhailArkhipov]

We can just flip the default. @qubitron ?

[qubitron]

I'm in favor of starting off conservative and having it off by default until we can do better auto-detection to avoid false-positives.

Let's not use the word "diagnostics" for these settings. Diagnostics means debugging/profiling/etc, let's stick to python.analysis.* for all analysis related items.

[batisteo]

Do we only have the choice between having a disturbing file tree with warnings and available symbols for the current opened files?

[qubitron]

@batisteo only seeing symbols for current opened files is not expected, and sounds like a bug, could you provide more details as to what you are seeing in #2231 ?

cc @brettcannon