Upgrade to latest LS protocol #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
approved these changes
Jul 16, 2018
src/client/activation/downloader.ts
Outdated
| @@ -42,7 +42,7 @@ export class LanguageServerDownloader { | |||
| let localTempFilePath = ''; | |||
| try { | |||
| localTempFilePath = await this.downloadFile(downloadUriPrefix, enginePackageFileName, 'Downloading Microsoft Python Language Server... '); | |||
| await this.verifyDownload(localTempFilePath, platformString); | |||
| // await this.verifyDownload(localTempFilePath, platformString); | |||
DonJayamanne
requested changes
Jul 16, 2018
|
@d3r3kk |
|
We can likely improve our vscode-mock loader to catch these problems. Added issue #2165. |
|
@DonJayamanne LOL, I've just taken @MikhailArkhipov's PR and usurped it to fix the missing type in vscode-mock. I'll see if I can make some sense of what you are asking 🤷♂️. |
Codecov Report
@@ Coverage Diff @@
## master #2164 +/- ##
==========================================
+ Coverage 79.86% 79.88% +0.01%
==========================================
Files 308 308
Lines 14176 14167 -9
Branches 2520 2519 -1
==========================================
- Hits 11322 11317 -5
+ Misses 2842 2838 -4
Partials 12 12
Continue to review full report at Codecov.
|
- Fix linter: unused private method. - Fix linter: unused imports
|
@DonJayamanne please have a look, I'll submit when the builds run clean. |
DonJayamanne
approved these changes
Jul 16, 2018
bschley
pushed a commit
to bschley/vscode-python
that referenced
this pull request
Aug 2, 2018
* LS symbol providers * Different ready wait * Upgrade dependencies to latest LS * Make open files only default * Turn off hash checks * Fix double progress display * Update packages * Anchor dependencies * Add missing mock from vscode-mock * Downgrade pylint to < 2.0.0 to mirror prospector requirements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to latest LS protocol since we need new CompletionItem field
Also
Fixes #2113
Fixes #2000