Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't stop linter #42

Closed
YuichiNukiyama opened this issue Nov 11, 2017 · 6 comments · Fixed by #241
Closed

Can't stop linter #42

YuichiNukiyama opened this issue Nov 11, 2017 · 6 comments · Fixed by #241
Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Milestone
December 2017

Comments

@YuichiNukiyama
Copy link

Environment data

VS Code version: 1.19 Insider
Python Extension version: 0.8.0
Python Version: 3.6.1
OS and version: Windows 10 1709

Actual behavior

Do nothing.

Expected behavior

When I push Disable Linter, stop linter and write disable option to settings.json

Steps to reproduce:

  • create python file.
  • save file.

operationimage
@DonJayamanne
Copy link

Please could you go into your .vscode directory and paste the contents of the settings.json file.

@YuichiNukiyama
Copy link
Author

VS Code create automatically .vscode folder, but don't settings.json.
And if I create manually settings.json* and write "python.linting.enabled": false, l can stop information.

@DonJayamanne
Copy link

Please could you try deleting that file and opening the Developer Tools from the menu, and let me know if there are any errors.

@YuichiNukiyama
Copy link
Author

I see.

Message of dev tools

fromdevtools

And debug information from source code

fromsourcecode

@YuichiNukiyama
Copy link
Author

I made an additional survey. When I push Disable Linter button, settings are written as enabledWithoutWorkspace instead of .vscode folder in user settings.
But, LinterProvider do not chech this this option. I sent PR(#47), so please refer.

@brettcannon brettcannon added awaiting 3-merge area-linting bug Issue identified by VS Code Team member as probable bug labels Nov 14, 2017
@brettcannon brettcannon mentioned this issue Nov 14, 2017
Merged
@DonJayamanne DonJayamanne mentioned this issue Nov 16, 2017
Merged
DonJayamanne added a commit that referenced this issue Nov 16, 2017
@DonJayamanne
Disable linter without workspaces (#241)
f9e2596 
* Fix microsoft/vscode#37627 (#1368)

* Version 0.7.0 of extension (#1381)

Archive of 0.7.0

* Update README.md

* Update README.md

* fix readme

* fixes #42 disable in workspace specific config
@DonJayamanne DonJayamanne reopened this Nov 17, 2017
@DonJayamanne DonJayamanne mentioned this issue Nov 17, 2017
Closed
@DonJayamanne DonJayamanne added this to the December 2017 milestone Nov 17, 2017
@DonJayamanne DonJayamanne mentioned this issue Nov 19, 2017
Closed
@DonJayamanne
Copy link

Fixed with #241

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
December 2017
Development

Successfully merging a pull request may close this issue.

Disable linter without workspaces DonJayamanne/pythonVSCode
3 participants
@brettcannon @DonJayamanne @YuichiNukiyama