Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Linter #47

Closed
wants to merge 2 commits into from
Closed

Disable Linter #47

wants to merge 2 commits into from

Conversation

YuichiNukiyama
Copy link

Disable Linter when not using workspace.

@YuichiNukiyama
Disable Linter
54d4555 
Disable Linter when not using workspace.
@YuichiNukiyama YuichiNukiyama mentioned this pull request Nov 11, 2017
Closed
DonJayamanne
DonJayamanne reviewed Nov 12, 2017
View reviewed changes
Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check needs to be made only when there are no workspace opened. Please modify accordingly (check if a workspace is open)

@YuichiNukiyama
Copy link
Author

Thanks your review. I modified my code.

@DonJayamanne
Copy link

DonJayamanne commented Nov 13, 2017 •
edited
Loading

@YuichiNukiyama, sorry to say, the fix is incorrect. The problem lies else where.
Closing this PR. Thanks for your effort though.

@YuichiNukiyama YuichiNukiyama deleted the disableLinter branch November 14, 2017 14:01
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DonJayamanne DonJayamanne DonJayamanne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuichiNukiyama @DonJayamanne