Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing a test file clears test status in test explorer #4576

Closed
DonJayamanne opened this issue Feb 27, 2019 · 3 comments
Closed

Editing a test file clears test status in test explorer #4576

DonJayamanne opened this issue Feb 27, 2019 · 3 comments
Assignees
@DonJayamanne
Labels
area-testing feature-request Request for new features or functionality
Milestone
2019, week 9 - Fe...

Comments

@DonJayamanne
Copy link

Work flow:

  • Run tests
  • 5 passed, 1 failed
  • Edit failing test file
  • Extension will re-discover tests
  • All status will be wiped clean

Questions:

  • How do we re-run failed tests
  • Should 5 passed tests sill appear as 5 passed
  • Should we just display 1 failed and other 5 have no status icon
@DonJayamanne DonJayamanne added feature-request Request for new features or functionality area-testing needs proposal Need to make some design decisions labels Feb 27, 2019
@qubitron
Copy link

Proposal:

  • If the same test exists after re-discovering tests, keep the last run status
  • Optionally change icon from "green pass" to a "white pass" icon to indicate pass status is fail

@DonJayamanne
Copy link
Author

Todo:

  • Modify src/client/unittests/common/services/storageService.ts
  • Merge results in storeTests method

@DonJayamanne DonJayamanne added needs PR needs proposal Need to make some design decisions and removed needs proposal Need to make some design decisions labels Feb 28, 2019
@DonJayamanne DonJayamanne self-assigned this Mar 4, 2019
@DonJayamanne DonJayamanne mentioned this issue Mar 4, 2019
Merged
4 tasks
@karrtikr
Copy link

karrtikr commented Mar 9, 2019

validated

@karrtikr karrtikr closed this as completed Mar 9, 2019
@ghost ghost removed needs PR needs proposal Need to make some design decisions labels Mar 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
area-testing feature-request Request for new features or functionality
Projects
None yet
Milestone
2019, week 9 - Feb Sprint 5
Development

No branches or pull requests
3 participants
@DonJayamanne @karrtikr @qubitron