Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve status of tests when re-discovering automatically #4638

Merged
merged 8 commits into from
Mar 7, 2019

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Mar 4, 2019

For #4576

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #4638 into master will decrease coverage by 1%.
The diff coverage is 89%.

@@           Coverage Diff           @@
##           master   #4638    +/-   ##
=======================================
- Coverage      77%     77%   -<1%     
=======================================
  Files         445     446     +1     
  Lines       21071   21260   +189     
  Branches     3422    3478    +56     
=======================================
+ Hits        16219   16294    +75     
- Misses       4846    4962   +116     
+ Partials        6       4     -2
Flag Coverage Δ
#Linux 66% <88%> (+1%) ⬆️
#Windows 66% <88%> (+1%) ⬆️
#macOS 66% <88%> (+1%) ⬆️

@DonJayamanne DonJayamanne force-pushed the issue4576 branch 2 times, most recently from 418a1b2 to f2c5465 Compare March 5, 2019 00:46
@DonJayamanne DonJayamanne marked this pull request as ready for review March 5, 2019 16:35
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general approach seems right, e.g. the merge functions. However, as I've noted below, I'm not convinced that things are happening in the right place.

src/client/unittests/common/services/storageService.ts Outdated Show resolved Hide resolved
src/client/unittests/common/services/storageService.ts Outdated Show resolved Hide resolved
src/client/unittests/common/services/storageService.ts Outdated Show resolved Hide resolved
src/client/unittests/common/services/storageService.ts Outdated Show resolved Hide resolved
src/client/unittests/common/services/storageService.ts Outdated Show resolved Hide resolved
src/client/unittests/common/services/storageService.ts Outdated Show resolved Hide resolved
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. LGTM.

@DonJayamanne DonJayamanne merged commit d4ea4b6 into microsoft:master Mar 7, 2019
@DonJayamanne DonJayamanne deleted the issue4576 branch May 24, 2019 20:25
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants