-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve status of tests when re-discovering automatically #4638
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4638 +/- ##
=======================================
- Coverage 77% 77% -<1%
=======================================
Files 445 446 +1
Lines 21071 21260 +189
Branches 3422 3478 +56
=======================================
+ Hits 16219 16294 +75
- Misses 4846 4962 +116
+ Partials 6 4 -2
|
418a1b2
to
f2c5465
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The general approach seems right, e.g. the merge functions. However, as I've noted below, I'm not convinced that things are happening in the right place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. LGTM.
For #4576
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)