Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bundled Jedi #674

Closed
segevfiner opened this issue Jan 31, 2018 · 6 comments
Closed

Upgrade bundled Jedi #674

segevfiner opened this issue Jan 31, 2018 · 6 comments
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone

Comments

@segevfiner
Copy link

Environment data

VS Code version: 1.19.3
Python Extension version: 0.9.1
Python Version: 2.7.12
OS and version: Ubuntu 16.04.3 x64

Jedi 1.11.1 is available. Might want to consider upgrading, assuming that the new version is better...

Note that it now depends on parso which will also need to be included.

@segevfiner segevfiner changed the title Upgrade Jedi Upgrade bundled Jedi Jan 31, 2018
@DonJayamanne
Copy link

We've looked the a previous version of Jedi, however there were a number of breaking changes.
This was looked at as part of #171

TODO: Guess its time to review this once again.

@DonJayamanne DonJayamanne added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. awaiting 1-verification debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Jan 31, 2018
@gandhis1
Copy link

gandhis1 commented Feb 1, 2018

+1 on this one, I know there's been a large number of fixes and improvements in recent versions. I've also had trouble in the past using anything but the bundled version of Jedi, not sure if these issues have been addressed lately or not.

@balta2ar
Copy link

balta2ar commented Feb 1, 2018

It looks like another version might be ready for a release soon (davidhalter/jedi#1031 (comment)) so maybe it's worth waiting a little more for it (though there is a risk to get stuck in such waiting for a while).

@MikhailArkhipov
Copy link

6015468

@segevfiner
Copy link
Author

@MikhailArkhipov I think I spot a few issues with the upgrade:

I can open a separate issue if you want.

@MikhailArkhipov
Copy link

Opened #773. Thanks for the pointers.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

6 participants