Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on Close redirects me to python.org #844

Closed
nikhilweee opened this issue Feb 21, 2018 · 3 comments · Fixed by #848
Closed

Clicking on Close redirects me to python.org #844

nikhilweee opened this issue Feb 21, 2018 · 3 comments · Fixed by #848
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@nikhilweee
Copy link

Environment data

VS Code version: 1.20.1
Python Extension version: 2018.1 (01 Feb 2018)
Python Version: 3.5.2
OS and version: Windows 10 Enterprise Version 1709 Build 16299.192

Actual behavior

Clicking on "Close" redirects me to python.org

Expected behavior

"Close" should just close the banner. It shouldn't redirect me anywhere.
It might help a bit if I am new to the world development, but in most other cases I'll probably end up installing python by myself. In my specific use case where there's no way to solve this yet (#67), this behavior is really annoying.

Steps to reproduce:

  • Open Bash on Ubuntu on Windows
  • Navigate to a project containing Python files
  • Open vscode $ code .
  • You get the following banner

Logs

Output from Python output panel

Linter 'pylint' is not installed. Please install it or select another linter".
Error: spawn python ENOENT

Output from Console window (Help->Developer Tools menu)


/C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:253 [Extension Host] Python Extension: Failed to get conda info from conda null
t.log @ /C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:253
/C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:253 [Extension Host] Python Extension: Linter 'pylint' is not installed. Please install it or select another linter". Error: spawn python ENOENT
	at exports._errnoException (util.js:1050:11)
	at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
	at onErrorNT (internal/child_process.js:367:16)
	at _combinedTickCallback (internal/process/next_tick.js:80:11)
	at process._tickCallback (internal/process/next_tick.js:104:9)
t.log @ /C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:253
/C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:2925 Linter pylint is not installed.
e.doShow @ /C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:2925
/C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:253 [Extension Host] rejected promise not handled within 1 second
t.log @ /C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:253
/C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:1306   ERR Git model not found
@DonJayamanne
Copy link

Please add the following setting into your user settings file settings.json:

"disableInstallationChecks":true

That should hide the banner.

@DonJayamanne
Copy link

@MikhailArkhipov
I agree, the close should just close the banner. How about adding a button with the label Help or Download?

@DonJayamanne DonJayamanne added feature-request Request for new features or functionality feature-extension labels Feb 21, 2018
@MikhailArkhipov
Copy link

OK.

@MikhailArkhipov MikhailArkhipov added this to the February 2018 milestone Feb 21, 2018
@MikhailArkhipov MikhailArkhipov self-assigned this Feb 21, 2018
MikhailArkhipov pushed a commit that referenced this issue Feb 21, 2018
* Fix pylint search

* Handle quote escapes in strings

* Escapes in strings

* CR feedback

* Missing pip

* Test

* Tests

* Tests

* Mac python path

* Tests

* Tests

* Test

* "Go To Python object" doesn't work

* Proper detection and type population in virtual env

* Test fixes

* Simplify venv check

* Remove duplicates

* Test

* Discover pylintrc better + tests

* Undo change

* CR feedback

* Set interprereter before checking install

* Fix typo and path compare on Windows

* Rename method

* #815 - 'F' in flake8 means warning

* 730 - same folder temp

* Properly resolve ~

* Test

* Test

* Fix dot spacing

* Remove banner

* Delete banner code
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants