#840, #844 #848
Merged
#840, #844 #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 16, 2018 10:50
added 8 commits
February 20, 2018 15:17
DonJayamanne
requested changes
Feb 21, 2018
| @@ -183,9 +182,6 @@ export async function activate(context: vscode.ExtensionContext) { | |||
| }); | |||
| activationDeferred.resolve(); | |||
|
|
|||
| // tslint:disable-next-line:no-unused-expression | |||
| new BannerService(persistentStateFactory); | |||
|
|
|||
| const deprecationMgr = new FeatureDeprecationManager(persistentStateFactory, !!jupyterExtension); | |||
There was a problem hiding this comment.
We should delete the files related to BannerService
There was a problem hiding this comment.
I thought we might need it to another banner just in case. But I guess it is easy to recover code from the history
DonJayamanne
approved these changes
Feb 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #844
Fixes #840
@as operatorsFixes #830