Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error logging of failure to identify location of conda #864

Closed
DonJayamanne opened this issue Feb 22, 2018 · 0 comments · Fixed by #871
Closed

Remove error logging of failure to identify location of conda #864

DonJayamanne opened this issue Feb 22, 2018 · 0 comments · Fixed by #871
Assignees
@DonJayamanne
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue
Milestone
February 2018

Comments

@DonJayamanne
Copy link

The following line of code is unnecessary.
this.logger.logError('Failed to get conda info from conda', ex);

Causes confusion amongst extension users.
This is merely an information message, and unnecessary.
@DonJayamanne DonJayamanne added good first issue needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Feb 22, 2018
@brettcannon brettcannon added this to the February 2018 milestone Feb 22, 2018
@DonJayamanne DonJayamanne mentioned this issue Feb 22, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue
Projects
None yet
Milestone
February 2018
Development

Successfully merging a pull request may close this issue.

remove unnecessary logging of error DonJayamanne/pythonVSCode
2 participants
@brettcannon @DonJayamanne