Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary logging of error #871

Merged
merged 2 commits into from
Feb 22, 2018

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Feb 22, 2018

Fixes #864

@codecov
Copy link

codecov bot commented Feb 22, 2018

Codecov Report

Merging #871 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
- Coverage   64.34%   64.05%   -0.29%     
==========================================
  Files         257      257              
  Lines       11859    11858       -1     
  Branches     2111     2111              
==========================================
- Hits         7631     7596      -35     
- Misses       4219     4253      +34     
  Partials        9        9
Impacted Files Coverage Δ
...ient/interpreter/locators/services/condaService.ts 97.29% <ø> (-0.03%) ⬇️
src/client/linters/errorHandlers/notInstalled.ts 33.33% <0%> (-61.12%) ⬇️
src/client/common/logger.ts 33.33% <0%> (-40.01%) ⬇️
src/client/linters/errorHandlers/errorHandler.ts 77.77% <0%> (-22.23%) ⬇️
src/client/common/application/applicationShell.ts 23.07% <0%> (-7.7%) ⬇️
src/client/linters/baseLinter.ts 85.41% <0%> (-6.25%) ⬇️
src/client/common/installer/productInstaller.ts 63.04% <0%> (-3.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 752709f...9a5250f. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 58be8f8 into microsoft:master Feb 22, 2018
@DonJayamanne DonJayamanne deleted the removeCondaErrorLogging branch March 2, 2018 21:34
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove error logging of failure to identify location of conda
2 participants