Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update launch.json schema to reflect that "env" values must be strings #9568

Closed
int19h opened this issue Jan 13, 2020 · 2 comments
Closed

Update launch.json schema to reflect that "env" values must be strings #9568

int19h opened this issue Jan 13, 2020 · 2 comments
Assignees
@karthiknadig @kimadeline
Labels
area-debugging bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Milestone
2020 January Sprint

Comments

@int19h
Copy link

int19h commented Jan 13, 2020

This is the extension-side counterpart to microsoft/ptvsd#1950 - since ptvsd 5 requires string values, the extension should reflect that.
@int19h int19h added the bug Issue identified by VS Code Team member as probable bug label Jan 13, 2020
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Jan 13, 2020
@luabud luabud mentioned this issue Jan 13, 2020
Closed
@karthiknadig karthiknadig added area-debugging needs PR important Issue identified as high-priority labels Jan 14, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jan 14, 2020
@luabud
Copy link
Member

luabud commented Jan 15, 2020

Proposed Solution

Add an additionalProperties field to define type string.

 "additionalProperties": { "type": "string" }

@luabud luabud added this to the 2020 January Sprint milestone Jan 15, 2020
@karthiknadig karthiknadig self-assigned this Jan 22, 2020
@karthiknadig karthiknadig mentioned this issue Jan 22, 2020
Merged
10 tasks
@kimadeline kimadeline self-assigned this Jan 24, 2020
@kimadeline
Copy link

✅ Validated on 2020.2.59860-dev:
image.png

@ghost ghost removed the needs PR label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karthiknadig karthiknadig

@kimadeline kimadeline

Labels
area-debugging bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Milestone
2020 January Sprint
Development

No branches or pull requests
5 participants
@brettcannon @int19h @karthiknadig @luabud @kimadeline