Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure environment variables are always strings in launch.json #9728

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

karthiknadig
Copy link
Member

For #9568

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@sonarcloud
Copy link

sonarcloud bot commented Jan 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #9728 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9728      +/-   ##
==========================================
- Coverage   60.71%   60.65%   -0.07%     
==========================================
  Files         552      552              
  Lines       29736    29778      +42     
  Branches     4495     4505      +10     
==========================================
+ Hits        18055    18061       +6     
- Misses      10670    10706      +36     
  Partials     1011     1011
Impacted Files Coverage Δ
...ence/interactive-common/intellisense/conversion.ts 36.11% <0%> (-3.02%) ⬇️
src/client/activation/refCountedLanguageServer.ts 37.2% <0%> (-2.8%) ⬇️
...active-common/intellisense/intellisenseProvider.ts 35.54% <0%> (-2.24%) ⬇️
src/client/activation/jedi.ts 21.21% <0%> (-0.67%) ⬇️
...ience/interactive-common/interactiveWindowTypes.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a52490...568e2ad. Read the comment docs.

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I guess the only real way to test this is manually. It may be worth adding to the test plan (or maybe not since we don't test any other part of that schema).

@karthiknadig karthiknadig merged commit 9238d01 into microsoft:master Jan 23, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
@karthiknadig karthiknadig deleted the issue9568 branch February 21, 2020 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants