Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple linters not working in VS Code #971

Closed
DonJayamanne opened this issue Mar 7, 2018 · 2 comments · Fixed by #973
Closed

Multiple linters not working in VS Code #971

DonJayamanne opened this issue Mar 7, 2018 · 2 comments · Fixed by #973
Assignees
Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@DonJayamanne
Copy link

DonJayamanne commented Mar 7, 2018

  • Open empty workspace in VSC
  • Enable at least 3 python linters
  • Create virtual environment
  • Create Python file
  • Select above virtual environment
  • Write some python code
  • You'll be prompted to install the linters
  • Install them one at a time (wait for each to complete)
  • After installing all, edit the code in the python file and save
  • None of the linters get executed

Solution: Restart VSC. Personally asking users to restart VSC is not a solution.

Bug is here lm.disableSessionLinting();

Somehow a message displayed by VSC gets dismissed by VSC, and the extension disables all messages.
The requirement should be that we NOT disable the linting, instead we should disable displaying the warning message.

Previously we had a message Do not display again message. We need something similar or we need to change the code to keep linting, and fail silently or some other solution.

@DonJayamanne
Copy link
Author

DonJayamanne commented Mar 7, 2018

@brettcannon is this a release blocker? I'd say it is.

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug area-linting needs PR labels Mar 7, 2018
@DonJayamanne
Copy link
Author

DonJayamanne commented Mar 7, 2018

Here's an easier way to replicate this (a more likely scenario):

  • Open empty workspace in VSC
  • Enable at least 3 python linters
  • Create virtual environment
  • Create Python file
  • Select above virtual environment
  • Write some python code
  • You'll get prompted to install pylint
  • User doesn't want pylint installed, hence dismisses the message
  • User goes into settings, disables pylint and enables flake8
  • VSC doesn't prompt user to install flake8 (even after editing and saving a python file)
  • Never mind, user manually installs flake8 into the environment
  • VSC doesn't lint the files using flake8

Problem - The act of dismissing the message Install Pylint has disabled linting for the current session.

@DonJayamanne DonJayamanne added this to the February 2018 milestone Mar 7, 2018
@MikhailArkhipov MikhailArkhipov self-assigned this Mar 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants