Change how we offer to install/disable linters #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 1, 2017 10:18
Codecov Report
@@ Coverage Diff @@
## master #973 +/- ##
==========================================
+ Coverage 64.01% 64.27% +0.25%
==========================================
Files 260 260
Lines 12027 12022 -5
Branches 2130 2129 -1
==========================================
+ Hits 7699 7727 +28
+ Misses 4319 4286 -33
Partials 9 9
Continue to review full report at Codecov.
|
DonJayamanne
approved these changes
Mar 7, 2018
| if (response === install) { | ||
| return this.install(product, resource); | ||
| } | ||
| const lm = this.serviceContainer.get<ILinterManager>(ILinterManager); | ||
| if (response === disable) { | ||
| if (response === disableAllLinting) { | ||
| await lm.enableLintingAsync(false); |
There was a problem hiding this comment.
Shouldn't the return value from here be InstallerResponse.Disabled?
| } else { | ||
| lm.disableSessionLinting(); | ||
| } else if (response === disableThisLinter) { | ||
| await lm.getLinterInfo(product).enableAsync(false); |
There was a problem hiding this comment.
Shouldn't the return value from here be InstallerResponse.Disabled?
added 3 commits
March 7, 2018 10:54
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #971
a. Install linter
b. Disable this linter
c. Disable all linters
Close button does nothing