Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility:MAS40B:Name and Help text values are empty for the top level menu #17172

Closed
WiproPSAccTest opened this issue Dec 14, 2016 · 11 comments
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues

Comments

@WiproPSAccTest
Copy link

WiproPSAccTest commented Dec 14, 2016

VSCode Version:1.6.1
OS Version:1607

Steps to Reproduce:
1.Open visual studio code editor.
2.Hit 'Alt+F' to open "File" menu bar option.

Expected Result:
Name and help text value should be present in the inspect tool for the "File" menu bar.

Actual Result:
Name and help text values are empty for the "File" menu bar option.
Note1: The same issue is observed in other (Edit,View,Go,Help) menu bar options.
Note2: Shortcut keys for "Command Pallete" are "f1" or "Ctrl+Shift+P".
Note3: Inspect and Narrator Buddy Information is attached

User Impact:
Screen reader will not recite the name of the menu bar name for the blind user accessing it.

inspectinformation_visualstudiocodeeditor_filemenubar
nvda announces as menu submenu for file menu bar

@kieferrm kieferrm added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Dec 14, 2016
@bpasero bpasero changed the title Accessibility: Name and Help text values are empty for the "File" menu bar in the inspect Tool. Name and Help text values are empty for the top level menu Dec 15, 2016
@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Dec 15, 2016
@bpasero bpasero added this to the Backlog milestone Dec 15, 2016
@WiproPSAccTest WiproPSAccTest changed the title Name and Help text values are empty for the top level menu Accessibility:MAS40B:Name and Help text values are empty for the top level menu Feb 1, 2017
@WiproPSAccTest
Copy link
Author

Title has been changed to a common format to perform data population.

@bpasero bpasero added workbench bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug labels Apr 7, 2017
@bpasero bpasero added the menu label May 26, 2017
@bpasero bpasero removed the workbench label Nov 15, 2017
@bpasero bpasero removed this from the Backlog milestone Nov 16, 2017
@bpasero
Copy link
Member

bpasero commented Jul 5, 2018

We should support this with the new custom menu implementation.

@sbatten sbatten added this to the July 2018 milestone Jul 5, 2018
@bpasero bpasero removed their assignment Jul 6, 2018
@sbatten
Copy link
Member

sbatten commented Jul 17, 2018

The user impact section of this is resolved, but I still don't see help text using the inspect tool. need more info to determine if this is resolved like #51841

@sbatten sbatten added the info-needed Issue requires more information from poster label Jul 17, 2018
@vscodebot vscodebot bot closed this as completed Jul 25, 2018
@vscodebot
Copy link

vscodebot bot commented Jul 25, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@sbatten sbatten reopened this Jul 26, 2018
@sbatten sbatten modified the milestones: July 2018, August 2018 Jul 28, 2018
@sbatten
Copy link
Member

sbatten commented Jul 28, 2018

Moving to August as we await clarification from @WiproPSAccTest

@vscodebot vscodebot bot closed this as completed Aug 5, 2018
@vscodebot
Copy link

vscodebot bot commented Aug 5, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@bpasero bpasero reopened this Aug 6, 2018
@AccessibilityTestingTeam-TCS

As per mentioned in link (https://code.visualstudio.com/updates/v1_25#_custom-title-bar-and-menus-for-windowslinux), the enhancements ex- menu bar accessible using arrow keys etc. work.

This issue still reproduces with the updated setting window.titleBarStyle : custom. Screen reader still does not read the name of the menu after pressing Alt + F (For opening menu as shown below)

menuissueusingkeros

Verified in below version of VS Code User Setup:

aboutvscode

@sbatten
Copy link
Member

sbatten commented Aug 23, 2018

@AccessibilityTestingTeam-TCS

In my branch, I've updated the structure to look like the following,
image

Though the name is present, it still does not announce the title of the menu when the user hits 'alt+f' as the focused item is the first menu item. However, if the user hits alt to focus the menu (indicating they want to learn the menu structure as opposed to already knowing where they are going by hitting alt+f) the screen reader reads the menu name and the shortcut. Does this meet the requirements?

@vscodebot
Copy link

vscodebot bot commented Sep 6, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@sbatten sbatten reopened this Sep 6, 2018
@AccessibilityTestingTeam-TCS

While we press Alt key, AT reads name and shortcuts for all menu items and navigates them using arrow keys, seems this fulfills the needed requirements.

@sbatten
Copy link
Member

sbatten commented Sep 19, 2018

Thanks for getting back. Closing as resolved.

@sbatten sbatten closed this as completed Sep 19, 2018
@sbatten sbatten removed the info-needed Issue requires more information from poster label Sep 19, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 3, 2018
@isidorn isidorn added the windows VS Code on Windows issues label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

7 participants