Put quotes around TestHost path so in case of spaces in name it starts correctly #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DavidKarlas, |
|
I made existing unit test more strict, I'm having problems building and running unit tests on my machine, but CI should be able to verify... |
codito
approved these changes
Sep 19, 2017
Faizan2304
approved these changes
Sep 19, 2017
DavidKarlas
pushed a commit
to mono/monodevelop
that referenced
this pull request
Sep 19, 2017
Issue was in vstest which is fixed in microsoft/vstest#1108 So this commit updates to latest version of vstest and changes logic around extracting path from arguments to remove new quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is issue for Visual Studio for Mac, because application is installed in "/Applications/Visual Studio.app/..." which means it has space in path..