Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put quotes around TestHost path so in case of spaces in name it starts correctly #1108

Merged
merged 3 commits into from
Sep 19, 2017
Merged

Put quotes around TestHost path so in case of spaces in name it starts correctly #1108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d5c3a3
Put quotes around TestHost path so in case of spaces in name it start…
Sep 18, 2017
bbdf5ee
Made unit test more strict to ensure path has quotes
Sep 19, 2017
1d9a718
Merge branch 'master' into hostPathQuotes
Faizan2304 Sep 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.TestPlatform.TestHostProvider/Hosting/DefaultTestHostManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ public virtual TestProcessStartInfo GetTestHostProcessStartInfo(
!this.processHelper.GetCurrentProcessFileName().EndsWith(DotnetHostHelper.MONOEXENAME, StringComparison.OrdinalIgnoreCase))
{
launcherPath = this.dotnetHostHelper.GetMonoPath();
argumentsString = testhostProcessPath + " " + argumentsString;
argumentsString = testhostProcessPath.AddDoubleQuote() + " " + argumentsString;
}

// For IDEs and other scenario, current directory should be the
Expand Down
2 changes: 1 addition & 1 deletion .../Microsoft.TestPlatform.TestHostProvider.UnitTests/Hosting/DefaultTestHostManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ public void GetTestHostProcessStartInfoShouldUseMonoAsHostOnNonWindowsIfNotStart
default(TestRunnerConnectionInfo));

Assert.AreEqual("/usr/bin/mono", info.FileName);
StringAssert.Contains(info.Arguments, "TestHost" + Path.DirectorySeparatorChar + "testhost.exe");
StringAssert.Contains(info.Arguments, "TestHost" + Path.DirectorySeparatorChar + "testhost.exe\"");
}

[TestMethod]
Expand Down