Fix socket exception on datacollection in parallel #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -596,6 +596,7 @@ private void SetOperationComplete() | |||
| EqtTrace.Verbose("TestRequestSender.SetOperationComplete: Setting operation complete."); | |||
| } | |||
|
|
|||
| this.communicationEndpoint.Stop(); | |||
There was a problem hiding this comment.
Do we need lock here?
| @@ -25,14 +25,19 @@ internal static class TcpClientExtensions | |||
| CancellationToken cancellationToken) | |||
| { | |||
| Exception error = null; | |||
| var remoteEndPoint = ((IPEndPoint)client.Client.RemoteEndPoint).ToString(); | |||
There was a problem hiding this comment.
do we need typecast?
| try | ||
| { | ||
| if (client.Client.Poll(STREAMREADTIMEOUT, SelectMode.SelectRead)) | ||
| { | ||
| EqtTrace.Verbose("TcpClientExtensions.MessageLoopAsync: NotifyDataAvailable remoteendPoint: {0} localEndPoint: {1}", remoteEndPoint, localEndPoint); |
There was a problem hiding this comment.
MessageLoopAsync [](start = 62, length = 16)
Lets see logs for this
| var connected = this.dataCollectionRequestSender.WaitForRequestHandlerConnection(this.connectionTimeout); | ||
| if (connected == false) | ||
| { | ||
| EqtTrace.Error("ProxyDataCollectionManager.Initialize: failed to connect to datacollector process."); |
There was a problem hiding this comment.
Add datacollector process ID we could not connect to
smadala
added a commit
to smadala/vstest
that referenced
this pull request
Mar 27, 2018
* Add more logging for datacollection manager * Skip additional messages * Add more logging * Add logging for MessageLoopAsync * Add logging for MessageLoopAsync 2 * Stop the communication server on operation complete * Add tests and remove not required logging * Address review comments
smadala
added a commit
that referenced
this pull request
Apr 2, 2018
* Fix socket exception on datacollection in parallel (#1505) * Add more logging for datacollection manager * Skip additional messages * Add more logging * Add logging for MessageLoopAsync * Add logging for MessageLoopAsync 2 * Stop the communication server on operation complete * Add tests and remove not required logging * Address review comments * Remove IPEndpoint typecast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
Related issue
#1472