[Port] Fix socket exception on datacollection in parallel #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add more logging for datacollection manager * Skip additional messages * Add more logging * Add logging for MessageLoopAsync * Add logging for MessageLoopAsync 2 * Stop the communication server on operation complete * Add tests and remove not required logging * Address review comments
| @@ -64,21 +65,22 @@ public string Start(string endPoint) | |||
|
|
|||
| this.tcpListener.Start(); | |||
|
|
|||
| var connectionInfo = ((IPEndPoint)this.tcpListener.LocalEndpoint).ToString(); | |||
| EqtTrace.Info("SocketServer: Listening on end point : {0}", connectionInfo); | |||
| this.endPoint = ((IPEndPoint)this.tcpListener.LocalEndpoint).ToString(); | |||
There was a problem hiding this comment.
nit: TypeCast was not needed
mayankbansal018
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #1505 for 15.7
Description
Fix
Related issue
#1472