Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12/1/2023 PM Publish #226

Merged
merged 1 commit into from
Dec 1, 2023
Merged

12/1/2023 PM Publish #226

merged 1 commit into from
Dec 1, 2023

Conversation

Taojunshen
Copy link

@Taojunshen Taojunshen commented Dec 1, 2023

Prior to this change, the documentation for the built-in Script resource made no mention of the drawbacks to using the resource and didn't direct readers to consider implementing their own resource instead.

This change:

  • Updates the note for the Script resource in the PSDscResources module to explicitly suggest readers implement a custom resource.
  • Adds the same note with the information about the drawbacks of the Script resource to the v1.1 built-in resource documentation.
  • Resolves Dsc Script Resource docs should discourage use #224
  • Fixes AB#187561

PR Summary

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

Prior to this change, the documentation for the built-in `Script`
resource made no mention of the drawbacks to using the resource and
didn't direct readers to consider implementing their own resource
instead.

This change:

- Updates the note for the `Script` resource in the **PSDscResources**
  module to explicitly suggest readers implement a custom resource.
- Adds the same note with the information about the drawbacks of the
  `Script` resource to the v1.1 built-in resource documentation.
- Resolves #224
- Fixes AB#187561
Copy link

Learn Build status updates of commit 86f4168:

✅ Validation status: passed

File Status Preview URL Details
dsc/docs-conceptual/dsc-1.1/reference/resources/windows/scriptResource.md ✅Succeeded View (dsc-1.1)
dsc/docs-conceptual/dsc-2.0/reference/PSDscResources/Resources/Script/Script.md ✅Succeeded View (dsc-2.0)

For more details, please refer to the build report.

For any questions, please:

@Taojunshen Taojunshen merged commit 8049799 into live Dec 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants