-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating Out-* commands with -NoNewLine per Issue 1739 #1846
Conversation
@zjalexander Please review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sniff I love the smell of cleaned-up documentation in the morning.
There's a few inconsistencies. I'll talk to you about whether it's easier to fix them now or to let them sit for a while.
## EXAMPLES | ||
|
||
### Example 1 | ||
``` | ||
|
||
```powershell | ||
PS C:\> add-content -path *.txt -exclude help* -value "END" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in other versions you cased the examples, but missed these.
|
||
Stream is a dynamic parameter that the FileSystem provider adds to the Add-Content cmdlet. This parameter works only in file system drives. | ||
Adds the content to the specified alternate data stream. If the stream does not yet, exist, Add-Content creates it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed some semantic linebreaks here
Specifies the path to the output file. | ||
Unlike **FilePath**, the value of the **LiteralPath** parameter is used exactly as it is typed. | ||
Unlike *FilePath*, the value of the *LiteralPath* parameter is used exactly as it is typed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the style guide, we have the following:
Property names and parameter names should be in bold
Add-Content [-Value] <Object[]> [-PassThru] -LiteralPath <String[]> [-Filter <String>] [-Include <String[]>] | ||
[-Exclude <String[]>] [-Force] [-Credential <PSCredential>] [-WhatIf] [-Confirm] [-UseTransaction] | ||
[-NoNewline] [-Encoding <FileSystemCmdletProviderEncoding>] [-Stream <String>] [<CommonParameters>] | ||
``` | ||
|
||
## DESCRIPTION | ||
The **Add-Content** cmdlet appends content to a specified item or file. | ||
|
||
The Add-Content cmdlet appends content to a specified item or file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, according to the style guide:
When talking about a cmdlet in paragraph, use ` to highlight cmdlet names
❌ Validation status: errors
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
updating Out-* commands with -NoNewLine per Issue #1739
Version(s) of document impacted