Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numerous extraneous backslash characters #1921

Closed
wants to merge 1 commit into from
Closed

Remove numerous extraneous backslash characters #1921

wants to merge 1 commit into from

Conversation

Adam-S-Daniel
Copy link

Replaced 180 instances of "$" with "$", reverting all affected variable mentions to their state from before commit c4201e1

Replaced 180 instances of "\$" with "$", reverting all affected variable mentions to their state from before commit c4201e1
@msftclas
Copy link

msftclas commented Dec 4, 2017

CLA assistant check
All CLA requirements met.

@saldana
Copy link
Contributor

saldana commented Dec 4, 2017

⚠️ Validation status: warnings

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/About/about_Preference_Variables.md ⚠️Warning Details

reference/5.1/Microsoft.PowerShell.Core/About/about_Preference_Variables.md

  • [Warning] Ignore metadata: locale. They are generated by open publish.

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@sdwheeler
Copy link
Contributor

Those backslash characters are not extraneous. They are required by the tools we use to publish the About topic. Please see Issue #1806 and the updated Style Guide.

@sdwheeler sdwheeler closed this Dec 4, 2017
@Adam-S-Daniel
Copy link
Author

Many of them are visible on the rendered page; they should not be.

@sdwheeler
Copy link
Contributor

Ok. I see some that need to be fixed. The backslash is not needed inside of a code block. I fixed those.

@Adam-S-Daniel Adam-S-Daniel deleted the patch-1 branch December 5, 2017 18:14
@Adam-S-Daniel
Copy link
Author

@sdwheeler - Thank you for pointing out those resources earlier and for addressing this so promptly and thoroughly. When I search the rendered page following your commits ab67cac and b0c3b79, I see that there are now 0 instances of \$ found versus 48 on the previous live version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants