-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Get-Module - less horizontal scrolling #2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
move commentary outside code-blocks to reduce horizontal scrolling
❌ Validation status: errors
reference/6/Microsoft.PowerShell.Core/Get-Module.md
' For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Added spacing around codefence block to clear build issue.
❌ Validation status: errors
reference/6/Microsoft.PowerShell.Core/Get-Module.md
' For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
@petervandivier I see what the error here is now, missed it the first read through. The MAML format only allows a code block and then a comment, but not another code block before another header is there. That's part of why all the comments where in the code block so that there was only one code block per header and it didn't violate the MAML formatting rules. I really like the direction of making it more readable (less scrolling)... can you find a way to do so, but only have one PS code block in each header (example) to stay within the MAML formatting rules? |
hopefully w/in guidelines & still improves readability. also took the opportunity to vertical-align the manifest example
|
🤞 hopefully this update suffices. the only other idea i had off the top of my head was to linebreak the comments within the markdown code blocks, but then it won't dynamically scale with screen size. |
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
This looks like an acceptable compromise between usability and the MAML rules. I'm going to have @sdwheeler take a look, too, before merging it in. |
Re-organizing content to be Intro, Example(s), Explanation.
|
@petervandivier @sdwheeler and I talked about this and decided to rotate the sections a bit to be more Intro, Example(s), Explanation in layout (keeping your changes, just re-ordering them). Really appreciate your contribution here and helping improve and streamline this content! |
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
@petervandivier Thanks again... with the update layout, we are merging in. Appreciate the contribution and help here! |
move commentary outside code-blocks to reduce horizontal scrolling