Skip to content

Update about_Foreach.md #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Update about_Foreach.md #4002

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
189227c
Update about_Foreach.md
sassdawe Mar 15, 2019
036752c
Merge branch 'staging' into patch-1
sdwheeler Mar 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions reference/5.1/Microsoft.PowerShell.Core/About/about_Foreach.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,19 +175,23 @@ function Get-FunctionPosition {
process {
try {
$filesToProcess = if ($_ -is [System.IO.FileSystemInfo]) {
Write-Verbose "From pipeline"
$_
} else {
$filesToProcess = Get-Item -Path $Path
Write-Verbose "From parameter, $Path"
Get-Item -Path $Path
Copy link
Collaborator

@sdwheeler sdwheeler Mar 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the assignment here? If this code path is used then the collection in the foreach loop is empty.

Copy link
Contributor Author

@sassdawe sassdawe Mar 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the if starts with $filesToProcess = if (... therefor inside the else script block you cannot assign value to the same variable. The else has to return something.
I tested it and didn't work.

Copy link
Collaborator

@sdwheeler sdwheeler Mar 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOH, I see it now. Thanks.

}
$parser = [System.Management.Automation.Language.Parser]
Write-Verbose "lets start the foreach loop on `$filesToProcess with $($filesToProcess.count) as count"
foreach ($item in $filesToProcess) {
Write-Verbose "$item"
if ($item.PSIsContainer -or
$item.Extension -notin @('.ps1', '.psm1')) {
continue
}
$tokens = $errors = $null
$ast = $parser::ParseFile($item.FullName, ([REF]$tokens),
([REF]$errors))
$parser::ParseFile($item.FullName, ([REF]$tokens),
([REF]$errors)) | Out-Null
if ($errors) {
$msg = "File '{0}' has {1} parser errors." -f $item.FullName,
$errors.Count
Expand Down