Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main > Live #1894

Merged
merged 10 commits into from
Jan 10, 2024
Merged

Main > Live #1894

merged 10 commits into from
Jan 10, 2024

Conversation

mattwojo
Copy link
Collaborator

@mattwojo mattwojo commented Jan 8, 2024

No description provided.

snikolaj and others added 9 commits January 4, 2024 16:17
* Fix broken code block

* Update broken wslconfig bookmark
Fix indent and numbering for better readability.
Some small formatting improvements.
Also added the command to restart the hns service.
Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
* Update wsl-containers.md

Running Dev Containers: **Open Folder in Container...** when using this guide is not / no longer correct, as most readers will already have opened the folder while connected to WSL based on the steps provided above. We need to use **Dev Containers: Reopen in Container** or it will fail to create the .devcontainer folder and devcontainer.json and give a (unfortunately not very clear) error message.


See also: https://code.visualstudio.com/docs/devcontainers/containers#_open-a-wsl-2-folder-in-a-container-on-windows
   
- Use the Dev Containers: Reopen in Container command from a folder already opened using the WSL extension.
- Select Dev Containers: Open Folder in Container... from the Command Palette (F1) and choose a WSL folder using the local \\wsl$ share (from the Windows side).

* Update wsl-containers.md

---------

Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
* Update faq.yml -- tiny grammar change 

'changes to locale to' -> 'changes the locale to'

* Update basic-commands.md

'If you running WSL' -> 'If you run WSL'

* Update basic-commands.md

* rephrase a long sentence
* swap order of two sentences to make example of command closer to the description of the command

example of command: `wsl --set-default-version 2`

* Update basic-commands.md

Replace 

wsl -u <Username>`, `wsl --user <Username>

with

wsl --user <Username>

`wsl -u <Username>` and `wsl --user <Username>` are equivalent. Both commands are correct for the section of the documentation, but the display of the commands in the documentation was incorrect due to the stray ticks and comma.
* Update gui-apps.md

If we are already referencing apt, why not just use apt to install google chrome?

* Update gui-apps.md

forgot --fix-missing

* Add a note to explain the command flags and path

---------

Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
Copy link
Contributor

Learn Build status updates of commit af2d996:

⚠️ Validation status: warnings

File Status Preview URL Details
WSL/intune.md ⚠️Warning View Details
WSL/basic-commands.md ✅Succeeded View
WSL/enterprise.md ✅Succeeded View
WSL/faq.yml ✅Succeeded View
WSL/file-permissions.md ✅Succeeded View
WSL/install.md ✅Succeeded View
WSL/install-on-server.md ✅Succeeded View
WSL/networking.md ✅Succeeded View
WSL/troubleshooting.md ✅Succeeded View
WSL/tutorials/gui-apps.md ✅Succeeded View
WSL/tutorials/wsl-containers.md ✅Succeeded View
WSL/tutorials/wsl-database.md ✅Succeeded View
WSL/wsl2-mount-disk.md ✅Succeeded View
WSL/wsl-config.md ✅Succeeded View

WSL/intune.md

  • Line 43, Column 293: [Warning: bookmark-not-found] Cannot find bookmark '#configuration-setting-for-wslconfig' in 'wsl-config.md', did you mean '#configuration-settings-for-wslconfig'?

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit e5a1772:

⚠️ Validation status: warnings

File Status Preview URL Details
WSL/docfx.json ⚠️Warning Details
WSL/basic-commands.md ✅Succeeded View
WSL/enterprise.md ✅Succeeded View
WSL/faq.yml ✅Succeeded View
WSL/file-permissions.md ✅Succeeded View
WSL/install.md ✅Succeeded View
WSL/install-on-server.md ✅Succeeded View
WSL/intune.md ✅Succeeded View
WSL/networking.md ✅Succeeded View
WSL/troubleshooting.md ✅Succeeded View
WSL/tutorials/gui-apps.md ✅Succeeded View
WSL/tutorials/wsl-containers.md ✅Succeeded View
WSL/tutorials/wsl-database.md ✅Succeeded View
WSL/wsl2-mount-disk.md ✅Succeeded View
WSL/wsl-config.md ✅Succeeded View

WSL/docfx.json

  • Line 41, Column 52: [Warning: value-deprecated-replace - See documentation] The 'ms.prod: dev-environment, ms.technology: windows-subsystem-for-linux' you used is now deprecated and can no longer be used. We suggest you replace it with 'ms.service: dev-environment, ms.subservice: windows-subsystem-for-linux'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@mattwojo mattwojo merged commit d90da18 into live Jan 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants