Update functions-dotnet-dependency-injection.md #108984
Conversation
Adding note about ASP.NET authentication
|
@brettsam : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
@fabiocav / @mattchenderson -- would like your eyes on this as well |
Adding note to troubleshooting topic...
|
Learn Build status updates of commit 155fdfe: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
prmerger-automator
bot
added
qualifies-for-auto-merge
and removed
qualifies-for-auto-merge
labels
|
Learn Build status updates of commit 9fd0aa5: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
| ### ASP.NET authentication overrides | ||
|
|
||
| Configuring ASP.NET authentication in a Functions startup class can override services that are required for the Azure portal to communicate with the host. This includes, but is not limited to, any calls to `AddAuthentication()`. If the host's authentication services are overridden and the portal cannot communicate with the host, it will consider the app unreachable. This may result in errors such as `No authentication handler is registered for the scheme 'ArmToken'.`. |
There was a problem hiding this comment.
This should be qualified as specifically a concern for .NET (in process only?). as this article is language agnostic.
| @@ -71,6 +71,8 @@ A series of registration steps run before and after the runtime processes the st | |||
|
|
|||
| - *The dependency injection container only holds explicitly registered types*. The only services available as injectable types are what are setup in the `Configure` method. As a result, Functions-specific types like `BindingContext` and `ExecutionContext` aren't available during setup or as injectable types. | |||
|
|
|||
| - *Configuring ASP.NET authentication is not supported*. The Functions host configures ASP.NET authentication services in order to properly expose APIs to infrastucture services, such as the Azure portal. Additional configuration in a custom Startup class can override this configuration, causing unintended consequences. For example, calling `builder.Services.AddAuthentication()` can break authentication between the portal and the host, leading to messages such as "Azure Functions runtime is unreachable". | |||
There was a problem hiding this comment.
The consequences here are broader than just portal scenarios, right? Any non-HttpTrigger endpoint would potentially be in scope, including extension endpoints, etc., right? Regardless, we might reframe that more as a specific example.
| - *Configuring ASP.NET authentication is not supported*. The Functions host configures ASP.NET authentication services in order to properly expose APIs to infrastucture services, such as the Azure portal. Additional configuration in a custom Startup class can override this configuration, causing unintended consequences. For example, calling `builder.Services.AddAuthentication()` can break authentication between the portal and the host, leading to messages such as "Azure Functions runtime is unreachable". | |
| - *Configuring ASP.NET authentication is not supported*. The Functions host configures ASP.NET authentication services in order to properly expose APIs for core lifecycle operations. Additional configuration in a custom Startup class can override this configuration, causing unintended consequences. For example, calling `builder.Services.AddAuthentication()` can break authentication between the portal and the host, leading to messages such as "Azure Functions runtime is unreachable". |
|
emailed GG |
|
emailed author |
|
@mattchenderson can you just grab BrettSam's commit into your fork with the other DI work? Sadly, he doesn't often return to these github issues (and you know where to find him 😉). |
|
sent reminder to ggailey777 |
|
@mattchenderson - Can you address this issue that's addressed to you? Or, @ggailey777 , should this again PR be closed? Thanks, jeff review team |
|
@mattchenderson - Can you address #108984 (comment) that's addressed to you? Alternatively, should this PR be closed, @ggailey777? |
|
Thanks @Stacyrch140 for the reminder. I do have the commits in my own private PR now so #please-close. |
Adding note about ASP.NET authentication
We've had support issues with this: Azure/azure-functions-host#6805. This is not likely to be something we add support for in-proc as we're moving towards dotnet-isolated in the future. We should start calling this out to help prevent support issues.