-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed error on documentation tabs #122362
Conversation
The tabs "In-Process" and "Isolated" were changed. The error is fixed with this changes.
@fjbelizon : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit b527e5c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
@fjbelizon can you please elaborate the reason for the change? What's the error? |
@zhenlan yes, of course. The tabs are changed. The information specifies, for example, the use of ‘ConfigureFunctionsWorkerDefaults()’ in Isolated Functions, however in this type of functions it is recommended to use ‘ConfigureFunctionsWebApplication()’ (at least if you use ASP.NET Core integration). Another problem is that the function ‘ConfigureFunctionsWorkerDefaults(app => app.UseAzureAppConfiguration())’ generates debugging problems, in functions that make use of context, such as Eternal Orchestration, etc. This is why the information in the ‘Isolated’ and ‘In-Proc’ tabs is wrong, the ‘In-Proc’ is the ‘Isolated’ and the ‘Isolated’ is the ‘In-Proc’. |
@fjbelizon thanks. I'm not sure the content should be swapped. But before I dive into it, is this related to the issue you reported here Azure/AppConfiguration#915? |
Yes @zhenlan, the problems are related |
@fjbelizon thanks for the confirmation. That issue is related to the durable functions. As discussed in Azure/AppConfiguration-DotnetProvider#484, it's more of an issue with middleware in durable. To work around the issue, you can skip the call to |
I do not think so. That is why I have opened the documentation issue and the middleware issue. You can take whatever solution you want, I have reported the problem that exists. Thank you very much. |
@zhenlan - Should this PR remain open or can it be closed? Thanks, PR review team |
@American-Dipper this PR can be closed. I may see if there is any improvement/clarification I can make to this document later. |
I hope it will be done, because the documentation is not correct. |
The tabs "In-Process" and "Isolated" were changed. The error is fixed with this changes.