Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code example in pre-post-events-schedule-maintenance-configuration.md #124643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josh-martin-1
Copy link

Fix webhook creation code. Previously was using New-AzEventGridSystemTopicEventSubscription -Endpoint $PreEventWebhookEndpoint, but -Endpoint is no longer a valid parameter starting in Azure PowerShell 12.3.0 (was supported in Azure PowerShell 11.6.0) - https://learn.microsoft.com/en-us/powershell/module/az.eventgrid/new-azeventgridsystemtopiceventsubscription

Fix webhook creation code. Previously was using  New-AzEventGridSystemTopicEventSubscription -Endpoint $PreEventWebhookEndpoint, but -Endpoint is no longer a valid parameter starting in Azure PowerShell 12.3.0 (was supported in Azure PowerShell 11.6.0)  - https://learn.microsoft.com/en-us/powershell/module/az.eventgrid/new-azeventgridsystemtopiceventsubscription
Copy link
Contributor

@josh-martin-1 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit f582e20:

💡 Validation status: suggestions

File Status Preview URL Details
articles/update-manager/pre-post-events-schedule-maintenance-configuration.md 💡Suggestion Details

articles/update-manager/pre-post-events-schedule-maintenance-configuration.md

  • Line 142, Column 69: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /rest/api/maintenance/maintenance-configurations/create-or-update?view=rest-maintenance-2023-09-01-preview&tabs=HTTP

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Oct 14, 2024

@SnehaSudhirG
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants