Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code highlighting in concepts-models.md #124653

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BartekSTRX
Copy link
Contributor

fix code highlighting - currently highlighted lines of code are out of sync with linked files

pics below show how it looks before the changes
Capture3
Capture2
Capture

fix code highlighting - currently highlighted lines of code are out of sync with linked files
Copy link
Contributor

@BartekSTRX : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit f6fab35:

✅ Validation status: passed

File Status Preview URL Details
articles/digital-twins/concepts-models.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Oct 15, 2024

@baanders
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Oct 15, 2024
Copy link
Contributor

@baanders baanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BartekSTRX for noticing that the highlights have become out-of-sync with the referenced IRoom.json file, and for taking the time to provide these updates!

I've requested some changes to your edits with explanations in the review comments. Please take a look at my review and let me know if you have any questions. Once they are addressed, we can merge this PR into main. :)

articles/digital-twins/concepts-models.md Show resolved Hide resolved
articles/digital-twins/concepts-models.md Show resolved Hide resolved
articles/digital-twins/concepts-models.md Show resolved Hide resolved
@BartekSTRX
Copy link
Contributor Author

@baanders all looks good, I think it can be merged

@baanders
Copy link
Contributor

Hi @BartekSTRX, thank you for reviewing my comments! In order to merge this pull request, you'll need to implement the requsted changes by adding a new commit.
Alternatively, I can make the updates myself in a separate PR and close this one if that is easier for you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants