Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some missing variable prefixes. #82224

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Conversation

jocawtho
Copy link
Contributor

No description provided.

@PRMerger16
Copy link
Contributor

@jocawtho : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver
Copy link
Contributor

#label:"aq-pr-triaged"

@PRMerger13 PRMerger13 added the aq-pr-triaged tracking label for the PR review team label Oct 11, 2021
@msangapu-msft
Copy link
Contributor

Also discussed here: dotnet/runtime#36123

#sign-off

@PRMerger3
Copy link
Contributor

@msangapu-msft: I'm sorry - only the author of this article, @cephalin, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@msangapu-msft
Copy link
Contributor

#reassign msangapu-msft

@PRMerger18 PRMerger18 assigned msangapu-msft and unassigned cephalin Oct 12, 2021
@msangapu-msft
Copy link
Contributor

#sign-off

@PRMerger5
Copy link
Contributor

@msangapu-msft: I'm sorry - only the author of this article, @cephalin, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@ktoliver ktoliver merged commit ba1e2c2 into MicrosoftDocs:master Oct 12, 2021
@msangapu-msft
Copy link
Contributor

Thank you @ktoliver

@deMD
Copy link

deMD commented Feb 22, 2022

Why was this merged? The variable prefixes are not planned until .Net 8+ #64015 and this PR even has the do-not-merge tag!

@msangapu-msft
Copy link
Contributor

Why was this merged? The variable prefixes are not planned until .Net 8+ #64015 and this PR even has the do-not-merge tag!

Hi @deMD please message me internally (msangapu) if this needs to be reverted.

@ktoliver
Copy link
Contributor

Hi @deMD - The do-not-merge label refers only to mergeability in regards to build validation, authorized approval, and so on. 👍🏼 The tag is applied automatically to all pull requests that are opened in this repository, and it doesn't analyze or refer to the accuracy or timeliness of the content that is updated in the PR. For more information, see https://docs.microsoft.com/contribute/how-to-write-workflows-major#validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants