Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sampling-classic-api.md #55

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brafonso7
Copy link

Updating link for Python fixed rate sampling in the table - the old one is sending customer to the deprecated Open Census

Updating link for Python fixed rate sampling in the table - the old one is sending customer to the deprecated Open Census
Copy link
Contributor

@brafonso7 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit c87c962:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/azure-monitor/app/sampling-classic-api.md ⚠️Warning Details

articles/azure-monitor/app/sampling-classic-api.md

  • Line 44, Column 115: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/azure-monitor/app/opentelemetry-configuration?tabs=python#enable-sampling' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 44, Column 115: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/azure-monitor/app/opentelemetry-configuration?tabs=python#enable-sampling' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 0ae3b84:

💡 Validation status: suggestions

File Status Preview URL Details
articles/azure-monitor/app/sampling-classic-api.md 💡Suggestion Details

articles/azure-monitor/app/sampling-classic-api.md

  • Line 44, Column 115: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-monitor/app/opentelemetry-configuration?tabs=python#enable-sampling' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@ttorble
Copy link
Contributor

ttorble commented Nov 29, 2024

@AaronMaxwell

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Nov 29, 2024
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Dec 13, 2024
@brafonso
Copy link

@AaronMaxwell any chance this change can be made?

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants