Skip to content

Add bunch of missing colons #5305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Rageking8
Copy link
Contributor

Add bunch of missing colons with some cleanups. Best reviewed one commit at a time.

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 1a1b847:

✅ Validation status: passed

File Status Preview URL Details
docs/atl/reference/iolecontrolimpl-class.md ✅Succeeded
docs/atl/reference/ipersiststorageimpl-class.md ✅Succeeded
docs/c-runtime-library/reference/itoa-itow.md ✅Succeeded
docs/cloud/cloud-and-web-programming-in-visual-cpp.md ✅Succeeded
docs/code-quality/c6029.md ✅Succeeded
docs/cpp/type-conversions-and-type-safety-modern-cpp.md ✅Succeeded
docs/cppcx/collections-c-cx.md ✅Succeeded
docs/cppcx/deprecating-types-and-members-c-cx.md ✅Succeeded
docs/data/oledb/crowset-class.md ✅Succeeded
docs/dotnet/functional-stl-clr.md ✅Succeeded
docs/extensions/string-cpp-component-extensions.md ✅Succeeded
docs/mfc/codesnippet/CPP/cmultidoctemplate-class_2.cpp ✅Succeeded
docs/mfc/codesnippet/CPP/csingledoctemplate-class_2.cpp ✅Succeeded
docs/mfc/reference/cmemfile-class.md ✅Succeeded
docs/mfc/reference/crecordset-class.md ✅Succeeded
docs/mfc/tn014-custom-controls.md ✅Succeeded
docs/overview/cpp-conformance-improvements-2019.md ✅Succeeded
docs/preprocessor/hash-import-directive-cpp.md ✅Succeeded
docs/standard-library/day-class.md ✅Succeeded
docs/standard-library/filesystem-functions.md ✅Succeeded
docs/standard-library/local_t.md ✅Succeeded
docs/standard-library/steady-clock-struct.md ✅Succeeded
docs/standard-library/view-classes.md ✅Succeeded
docs/standard-library/zoned-time-class.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Changed Files This PR contains more than 10 changed files.
Unapproved file extension(s) This PR contains file types that are not supported in the repo. The only supported file types are jpg, gif, png, json, svg and md.

@@ -43,7 +43,7 @@ In C++, you have several options for connecting to the web and the cloud.

- [Windows::Web::Http::HttpClient](/uwp/api/windows.web.http.httpclient)

A Windows Runtime HTTP client class modeled on the .NET Framework class of the same name in the System.Web namespace. `HttpClient` fully supports asynchronous upload and download over HTTP, and pipeline filters that enable the insertion of custom HTTP handlers into the pipeline. The Windows SDK includes sample filters for metered networks, OAuth authentication, and more. For apps that target only Universal Windows Platform, we recommend that you use the `Windows::Web:HttpClient` class.
A Windows Runtime HTTP client class modeled on the .NET Framework class of the same name in the System.Web namespace. `HttpClient` fully supports asynchronous upload and download over HTTP, and pipeline filters that enable the insertion of custom HTTP handlers into the pipeline. The Windows SDK includes sample filters for metered networks, OAuth authentication, and more. For apps that target only Universal Windows Platform, we recommend that you use the `Windows::Web::Http::HttpClient` class.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be Windows::Web::Http::HttpClient instead of Windows::Web::HttpClient.

@@ -2,7 +2,7 @@
title: "local_t struct"
description: "Learn more about: local_t struct"
ms.date: 09/02/2021
f1_keywords: ["chrono/std::chrono::local_t", chrono/std::chrono::local_t:local_time", "chrono/std::chrono::local_days", "chrono/std::chrono::local_seconds"]
f1_keywords: ["chrono/std::chrono::local_t", chrono/std::chrono::local_time", "chrono/std::chrono::local_days", "chrono/std::chrono::local_seconds"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local_time should be in std::chrono instead of std::chrono::local_t.

@ttorble
Copy link
Contributor

ttorble commented Apr 22, 2025

@TylerMSFT

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants