Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds dependencies filter documentation #110

Merged
merged 7 commits into from
Sep 29, 2024
Merged

feat: adds dependencies filter documentation #110

merged 7 commits into from
Sep 29, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented Sep 12, 2024

@baywet
feat: adds dependencies filter documentation
5f78010 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet requested a review from a team as a code owner September 12, 2024 15:07
@baywet baywet self-assigned this Sep 12, 2024
@baywet baywet enabled auto-merge September 12, 2024 15:07
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
sebastienlevert
sebastienlevert previously requested changes Sep 12, 2024
View reviewed changes
OpenAPI/kiota/using.md Outdated Show resolved Hide resolved
@baywet
fix: formats as table
c1fa43c 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@baywet
adds a language to the example
f313a59 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet disabled auto-merge September 13, 2024 13:10
@baywet
docs: adds dependencies topic
8d95e43 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: adds kiota as a known word
ab76ab0 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
feat: updates quick start to use bundles
42b84f0 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@baywet
Copy link
Member Author

baywet commented Sep 13, 2024

@sebastienlevert your last comment prompted me to realize I had not updated the quick start, which also required some kind of guidance around dependencies management. Hopefully this results in a much better experience.

@baywet
fix: adds s and ds arguments for java to workaround dependency manage…
c594af6 
…ment and migration command

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit c594af6:

✅ Validation status: passed

File Status Preview URL Details
.vscode/settings.json ✅Succeeded
OpenAPI/kiota/dependencies.md ✅Succeeded
OpenAPI/kiota/quickstarts/cli.md ✅Succeeded
OpenAPI/kiota/quickstarts/dotnet.md ✅Succeeded
OpenAPI/kiota/quickstarts/go.md ✅Succeeded
OpenAPI/kiota/quickstarts/java.md ✅Succeeded
OpenAPI/kiota/quickstarts/typescript.md ✅Succeeded
OpenAPI/kiota/toc.yml ✅Succeeded
OpenAPI/kiota/tutorials/cli-azure.md ✅Succeeded
OpenAPI/kiota/tutorials/dotnet-azure.md ✅Succeeded
OpenAPI/kiota/tutorials/dotnet-dependency-injection.md ✅Succeeded
OpenAPI/kiota/tutorials/go-azure.md ✅Succeeded
OpenAPI/kiota/tutorials/java-azure.md ✅Succeeded
OpenAPI/kiota/tutorials/typescript-azure.md ✅Succeeded
OpenAPI/kiota/using.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

This was referenced Sep 13, 2024
Merged
Open
Closed
Open
@MicrosoftDocs MicrosoftDocs deleted a comment from frankandrea221 Sep 16, 2024
frankandrea221
frankandrea221 reviewed Sep 29, 2024
View reviewed changes
Copy link

@frankandrea221 frankandrea221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AAA

frankandrea221
frankandrea221 reviewed Sep 29, 2024
View reviewed changes
Copy link

@frankandrea221 frankandrea221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AAA

@baywet baywet dismissed sebastienlevert’s stale review September 29, 2024 12:46

Concerns have been addressed

@baywet baywet merged commit 5e6fdf4 into main Sep 29, 2024
3 checks passed
@baywet baywet deleted the feat/type-argument branch September 29, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankandrea221 frankandrea221 frankandrea221 left review comments

@andrueastman andrueastman andrueastman approved these changes

@sebastienlevert sebastienlevert Awaiting requested review from sebastienlevert

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baywet @andrueastman @sebastienlevert @frankandrea221