-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet tutorial kiota dependency injection #89
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this great contribution!
A first round of initial feedback. That plus suggesting moving the sample to kiota samples so it can be referenced here instead of copied.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@baywet I've just updated the PR with the changes in the library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the updates.
I think we're getting really close!
Are you planning to add the sample in the kiota samples repo so we can use references here instead?
Yes, I'll be doing that today. Does it already have a generated client I can use? So I can skip that part? |
First hurdle below, solution:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Learn Build status updates of commit 02eb45a: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@baywet I've changed it to download the github specs with the kiota client and to generated based upon that. Also changed the highlighting part. Because of all the commits it took, I suggest to Squash this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the continuous effort on this one it will be a great addition to current documentation.
Any idea when this new page will be live? Is there some sort of "learn weekly deploy"? |
fix: accrolinx report after merge of #89
Now that #103 has been merged, it should be within the day. |
Fixed #37