Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet tutorial kiota dependency injection #89

Merged
merged 13 commits into from
Jul 2, 2024

Conversation

svrooij
Copy link
Contributor

@svrooij svrooij commented May 10, 2024

Fixed #37

@svrooij svrooij requested a review from a team as a code owner May 10, 2024 08:32

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@svrooij
Copy link
Contributor Author

svrooij commented May 10, 2024

@baywet here is my tutorial for Kiota with DI solving issue #37

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great contribution!
A first round of initial feedback. That plus suggesting moving the sample to kiota samples so it can be referenced here instead of copied.

OpenAPI/kiota/toc.yml Outdated Show resolved Hide resolved
OpenAPI/kiota/tutorials/dotnet-dependencyinjection.md Outdated Show resolved Hide resolved
OpenAPI/kiota/tutorials/dotnet-dependencyinjection.md Outdated Show resolved Hide resolved
OpenAPI/kiota/tutorials/dotnet-dependencyinjection.md Outdated Show resolved Hide resolved
OpenAPI/kiota/tutorials/dotnet-dependencyinjection.md Outdated Show resolved Hide resolved
OpenAPI/kiota/tutorials/dotnet-dependencyinjection.md Outdated Show resolved Hide resolved
OpenAPI/kiota/tutorials/dotnet-dependencyinjection.md Outdated Show resolved Hide resolved
OpenAPI/kiota/tutorials/dotnet-dependencyinjection.md Outdated Show resolved Hide resolved
OpenAPI/kiota/tutorials/dotnet-dependencyinjection.md Outdated Show resolved Hide resolved
OpenAPI/kiota/tutorials/dotnet-dependencyinjection.md Outdated Show resolved Hide resolved

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@svrooij
Copy link
Contributor Author

svrooij commented May 22, 2024

@baywet I've just updated the PR with the changes in the library

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates.
I think we're getting really close!
Are you planning to add the sample in the kiota samples repo so we can use references here instead?

OpenAPI/kiota/tutorials/dotnet-dependency-injection.md Outdated Show resolved Hide resolved
OpenAPI/kiota/tutorials/dotnet-dependency-injection.md Outdated Show resolved Hide resolved
OpenAPI/kiota/tutorials/dotnet-dependency-injection.md Outdated Show resolved Hide resolved
OpenAPI/kiota/tutorials/dotnet-dependency-injection.md Outdated Show resolved Hide resolved
@svrooij
Copy link
Contributor Author

svrooij commented May 23, 2024

Are you planning to add the sample in the kiota samples repo so we can use references here instead?

Yes, I'll be doing that today. Does it already have a generated client I can use? So I can skip that part?

@svrooij
Copy link
Contributor Author

svrooij commented May 23, 2024

Are you planning to add the sample in the kiota samples repo so we can use references here instead?

Yes, I'll be doing that today. Does it already have a generated client I can use? So I can skip that part?

First hurdle below, solution: git config --system core.longpaths true

Cloning into 'ms-kiota-samples'...
remote: Enumerating objects: 96280, done.
remote: Counting objects: 100% (4770/4770), done.
remote: Compressing objects: 100% (1740/1740), done.
remote: Total 96280 (delta 3228), reused 4443 (delta 2981), pack-reused 91510
Receiving objects: 100% (96280/96280), 23.33 MiB | 20.95 MiB/s, done.
Resolving deltas: 100% (69230/69230), done.
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/MailFolders/Item/ChildFolders/Item/Messages/Item/MultiValueExtendedProperties/Item/MultiValueLegacyExtendedPropertyItemRequestBuilderfbdb00d62c7a8f0e2c85cf8cf3ab976d75b4161f94af95af394cded9032b9711.swift: Filename too long
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/MailFolders/Item/ChildFolders/Item/Messages/Item/MultiValueExtendedProperties/MultiValueExtendedPropertiesRequestBuilder73077495a2575b048d523418fec9ad4c654063e879cbdce3ddec0500de0bc5a1.swift: Filename too long
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/MailFolders/Item/ChildFolders/Item/Messages/Item/SingleValueExtendedProperties/Item/SingleValueLegacyExtendedPropertyItemRequestBuilder25ba096782140d1312334fc503c5a36018b4a791080aa2e0fc674bf1db569203.swift: Filename too long
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/MailFolders/Item/ChildFolders/Item/Messages/Item/SingleValueExtendedProperties/SingleValueExtendedPropertiesRequestBuilder40733ae55d40d3e6ddcf10856d0d3f5240a9e3f2d2eb06b4eefa28b0fe72438c.swift: Filename too long
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/MailFolders/Item/ChildFolders/Item/MultiValueExtendedProperties/Item/MultiValueLegacyExtendedPropertyItemRequestBuilder5b55a97c5b0d8e76b5af72625258811ae7902b3792ca4f9ebaccab25e7570c93.swift: Filename too long
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/MailFolders/Item/ChildFolders/Item/MultiValueExtendedProperties/MultiValueExtendedPropertiesRequestBuilder13e11e0482d79ca042f52ca4b3f44d026c03616a2e5f5096bb9fb6862187e014.swift: Filename too long
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/MailFolders/Item/ChildFolders/Item/SingleValueExtendedProperties/Item/SingleValueLegacyExtendedPropertyItemRequestBuilder2686d0ca41ecb14e743a2ff4fa5506bccbd6e801c007ed052916719e94058282.swift: Filename too long
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/MailFolders/Item/ChildFolders/Item/SingleValueExtendedProperties/SingleValueExtendedPropertiesRequestBuilder2395afc9cbd74fb96b1da02a06ca5cd6e272b0ce008816388764df1c74bdf7d1.swift: Filename too long
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/MailFolders/Item/Messages/Item/MultiValueExtendedProperties/Item/MultiValueLegacyExtendedPropertyItemRequestBuilderfa30ff984bb890f890a81a3bc7bd08d649bdb6073054a279850aba7936dd05b3.swift: Filename too long
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/MailFolders/Item/Messages/Item/MultiValueExtendedProperties/MultiValueExtendedPropertiesRequestBuilder154c3234197de6208140c367f7b8a9d1c739ac30c517b3d24a6cb21e0eb4b7be.swift: Filename too long
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/MailFolders/Item/Messages/Item/SingleValueExtendedProperties/Item/SingleValueLegacyExtendedPropertyItemRequestBuilder75d57878e729fc875dc49115cf22144dc3e782f633c1ccc6c65cbd3a0bebb1c6.swift: Filename too long
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/MailFolders/Item/Messages/Item/SingleValueExtendedProperties/SingleValueExtendedPropertiesRequestBuilder2de3f5c488403b53e53405ebf1ebb0e3618f3cc4ccba117f06a613bfbd9775f7.swift: Filename too long
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/MailFolders/Item/MultiValueExtendedProperties/Item/MultiValueLegacyExtendedPropertyItemRequestBuilder6eb08fd81a0441d1c7cef789191817cf5800368a25e7eaec6fa4b4b839b3515f.swift: Filename too long
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/MailFolders/Item/SingleValueExtendedProperties/Item/SingleValueLegacyExtendedPropertyItemRequestBuilderb8a911797ce2a5d481a7353354a030cbe3b5501c5e56ccf3d70654cde0b6b8a6.swift: Filename too long
error: unable to create file msgraph-mail/swiftconsoleapp/Sources/swiftconsoleapp/Users/Item/Messages/Item/SingleValueExtendedProperties/Item/SingleValueLegacyExtendedPropertyItemRequestBuilder077fc46278ec970290bb1f54c2402167a1e4e858a97f0a924c1fc4f1a0ba5cae.swift: Filename too long
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Contributor

Learn Build status updates of commit 02eb45a:

✅ Validation status: passed

File Status Preview URL Details
cspell.json ✅Succeeded
OpenAPI/kiota/toc.yml ✅Succeeded
OpenAPI/kiota/tutorials/dotnet-azure.md ✅Succeeded
OpenAPI/kiota/tutorials/dotnet-dependency-injection.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@svrooij
Copy link
Contributor Author

svrooij commented Jun 29, 2024

@baywet I've changed it to download the github specs with the kiota client and to generated based upon that. Also changed the highlighting part.

Because of all the commits it took, I suggest to Squash this PR

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the continuous effort on this one it will be a great addition to current documentation.

@baywet baywet merged commit 41ba669 into MicrosoftDocs:main Jul 2, 2024
3 checks passed
@svrooij svrooij deleted the tutorial-kiota-dotnet-di branch July 2, 2024 20:54
@svrooij
Copy link
Contributor Author

svrooij commented Jul 2, 2024

Any idea when this new page will be live? Is there some sort of "learn weekly deploy"?

baywet added a commit that referenced this pull request Jul 3, 2024
@baywet
Copy link
Member

baywet commented Jul 3, 2024

Now that #103 has been merged, it should be within the day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add documentation on how to configure ASP.NET dependency injection for kiota client
3 participants