Skip to content

Denodo: added documentation for new options in version 1.1.0 of the connector #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

denodo-research-labs
Copy link
Contributor

This PR includes the modifications to the documentation that correspond to the new options in version 1.1.0 of the Denodo Connector, just submitted for certification.

Changes include:

  • Added Microsoft Entra ID authentication (fixed credentials).

@prmerger-automator prmerger-automator bot added the do-not-merge Don't merge this yet label Jun 13, 2025
Copy link
Contributor

Learn Build status updates of commit 0abd08b:

💡 Validation status: suggestions

File Status Preview URL Details
powerquery-docs/connectors/media/denodo/denodo-aad-authentication.png 💡Suggestion Details
powerquery-docs/connectors/media/denodo/denodo-aad-authentication2.png 💡Suggestion Details
powerquery-docs/connectors/media/denodo/denodo-aad-authentication3.png 💡Suggestion Details
powerquery-docs/connectors/denodo.md ✅Succeeded

powerquery-docs/connectors/media/denodo/denodo-aad-authentication.png

  • Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation] The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

powerquery-docs/connectors/media/denodo/denodo-aad-authentication2.png

  • Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation] The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

powerquery-docs/connectors/media/denodo/denodo-aad-authentication3.png

  • Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation] The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Image File This PR added or updated an image file(s).

@v-regandowner
Copy link
Contributor

@DougKlopfenstein - Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@denodo-research-labs
Copy link
Contributor Author

Validator is complaning about things like:

...media/denodo/denodo-aad-authentication.png

The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

Should we replace those "aad" in the file names with "entraid" instead?

@DougKlopfenstein
Copy link
Collaborator

You could either add "entra-id" (for example "denodo-entra-id-authentication-2.png") or just remove "aad" (for example "denodo-authentication-2.png"). Add a dash between "authentication" and the number just to be sure the name is accepted. Also be sure to change the names in the image metadata in the .md file as well.

Copy link
Contributor

Learn Build status updates of commit 3a8d986:

💡 Validation status: suggestions

File Status Preview URL Details
powerquery-docs/connectors/media/denodo/denodo-entra-id-authentication.png 💡Suggestion Details
powerquery-docs/connectors/media/denodo/denodo-entra-id-authentication2.png 💡Suggestion Details
powerquery-docs/connectors/media/denodo/denodo-entra-id-authentication3.png 💡Suggestion Details
powerquery-docs/connectors/denodo.md ✅Succeeded

powerquery-docs/connectors/media/denodo/denodo-entra-id-authentication.png

  • Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation] The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

powerquery-docs/connectors/media/denodo/denodo-entra-id-authentication2.png

  • Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation] The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

powerquery-docs/connectors/media/denodo/denodo-entra-id-authentication3.png

  • Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation] The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Image File This PR added or updated an image file(s).

@denodo-research-labs
Copy link
Contributor Author

We didn't add a hyphen before the numbers, but it still doesn't seem to like "denodo-entra-id-authentication.png", which has no number. So it may be "id" or even "denodo" itself. Those "See documentation" links throw a 404, how can we access information about those validation rules to understand what the validator does not like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants