Public PRs #238
Public PRs #238
Conversation
For some reason they were tagged as bash, which broke highlighting in at least one of them.
in line 98 it's `C:\\path\\to\\icon.png` while in line 115 it was `C:\\path\\to\\icon` so I've added the missing `.png`
From #135 * Add icon example and folder location As originally submitted by @aloneguid in #135 * Remove code brackets for readability * Add spacing
* Add info about the command palette 1. Add info about the command palette. 2. Typo fixes (e.g. "quick-start guide" instead of "quickstart") 3. Style fix, e.g. we don't have a keyboard key whose full name is "alt+shift+plus". * revert description Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
...from PR #181
* Add a note about hiding dynamic profiles * Minor writing updates Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
This seems to be the intended meaning: There are Linux distributions that are not Ubuntu, but Ubuntu is an example of a Linux distribution for which the behavior is the given.
Currently, the install recommends using an out-of-date version of golang, which in turn causes issues while installing powerline-go.
* Add startingDirectory example * Format startingDirectory entry
| The icon image file will need to be placed in a location that the Terminal app can read. Place icon images in the Windows Terminal AppData folder, located at: <br> | ||
|
|
||
| `%LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\RoamingState` | ||
| <br> | ||
| <br> | ||
| As an example, if you place the icon image `ubuntu.ico` in this folder, the property will be `"icon": "ms-appdata:///roaming/ubuntu.ico"`. |
There was a problem hiding this comment.
This is not true, icon image files can be anywhere on the machine.
| The icon image file will need to be placed in a location that the Terminal app can read. Place icon images in the Windows Terminal AppData folder, located at: <br> | |
| `%LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\RoamingState` | |
| <br> | |
| <br> | |
| As an example, if you place the icon image `ubuntu.ico` in this folder, the property will be `"icon": "ms-appdata:///roaming/ubuntu.ico"`. |
There was a problem hiding this comment.
Should we show a couple of different examples that illustrate this to reduce confusion?
There was a problem hiding this comment.
I just changed this from a descriptor to an example - how does this look? 65c6d39
Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
|
Docs Build status updates of commit 82a2f56: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 65c6d39: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
|
Docs Build status updates of commit 6090a3e: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
|
Docs Build status updates of commit ca0e2ab: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
|
Docs Build status updates of commit 214341c: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
|
Docs Build status updates of commit 394060f: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 1a2ab63: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
| @@ -95,8 +93,9 @@ This sets the icon that displays within the tab, dropdown menu, jumplist, and ta | |||
|
|
|||
| **Accepts:** File location as a string, or an emoji | |||
|
|
|||
| <br /> | |||
| **Example:** Placing the icon image `ubuntu.ico` in the folder located at `%LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\RoamingState`, you can display the icon by adding this line to the profile in your settings.json: `"icon": "ms-appdata:///roaming/ubuntu.ico"`. | |||
There was a problem hiding this comment.
| **Example:** Placing the icon image `ubuntu.ico` in the folder located at `%LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\RoamingState`, you can display the icon by adding this line to the profile in your settings.json: `"icon": "ms-appdata:///roaming/ubuntu.ico"`. | |
| **Example:** By placing the icon image `ubuntu.ico` in the folder located at `%LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\RoamingState`, you can display the icon by adding this line to the profile in your settings.json: `"icon": "ms-appdata:///roaming/ubuntu.ico"`. |
|
Ok - I mean, I'm kinda all about small nits and would be happy to fix, but I'm just going to merge and then we can fix in the main branch to include in the next push live. |
No description provided.