Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Push Service returns wrong status code 406 instead of 429 #4166

Closed
collimarco opened this issue Nov 27, 2022 · 1 comment
Closed
Assignees
Labels

Comments

@collimarco
Copy link

Please take a look at this related issue in the web push libraries:

zaru/webpush#103

It doesn't make sense and it is against web standards to return a 406 for rate limiting. 406 has a very specific meaning.

This causes serious problems to the web push libraries, but it cannot be solved inside the libraries (because the libraries are correct and need to follow the standard).

Please consider fixing this wrong behavior and updating your documentation here:

https://learn.microsoft.com/en-us/windows/apps/design/shell/tiles-and-notifications/push-request-response-headers#response-codes

Please mention/tag the right team. Thanks

@drewbatgit
Copy link
Contributor

@collimarco Thanks for your feedback about this issue. I've notified the feature team and asked them to take a look. Since this appears to be a code issue with the feature and issues in this repo are specifically intended to address the documentation, I'm going to go ahead and mark this issue as closed, but the feature team will revisit the issue and may continue the conversation.

learn-build-service-prod bot pushed a commit that referenced this issue Mar 20, 2024
…oys-fix-kbm-tables

Fix table formatting by adding line breaks on Keyboard Manager page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants